You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/01/12 15:29:17 UTC
[GitHub] [hudi] codope opened a new pull request #4574: [HUDI-3235] Fix ClassNotFoundException due to log4j-core dependency
codope opened a new pull request #4574:
URL: https://github.com/apache/hudi/pull/4574
## What is the purpose of the pull request
Some of the tests that need hive service to be setup also need log4j-core `Appender` instantiating `SessionManager` of hive service. This is only needed for test. Added it as a new dep with test scope.
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4574: [HUDI-3235] Fix ClassNotFoundException due to log4j-core dependency
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4574:
URL: https://github.com/apache/hudi/pull/4574#issuecomment-1011184381
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5154",
"triggerID" : "3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb",
"triggerType" : "PUSH"
}, {
"hash" : "9adc0b3cda58cdb3cfd399326b5fefb3cbf69f20",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9adc0b3cda58cdb3cfd399326b5fefb3cbf69f20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5154)
* 9adc0b3cda58cdb3cfd399326b5fefb3cbf69f20 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4574: [HUDI-3235] Fix ClassNotFoundException due to log4j-core dependency
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4574:
URL: https://github.com/apache/hudi/pull/4574#issuecomment-1011184381
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5154",
"triggerID" : "3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb",
"triggerType" : "PUSH"
}, {
"hash" : "9adc0b3cda58cdb3cfd399326b5fefb3cbf69f20",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9adc0b3cda58cdb3cfd399326b5fefb3cbf69f20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5154)
* 9adc0b3cda58cdb3cfd399326b5fefb3cbf69f20 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4574: [HUDI-3235] Fix ClassNotFoundException due to log4j-core dependency
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4574:
URL: https://github.com/apache/hudi/pull/4574#issuecomment-1011187966
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5154",
"triggerID" : "3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb",
"triggerType" : "PUSH"
}, {
"hash" : "9adc0b3cda58cdb3cfd399326b5fefb3cbf69f20",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5155",
"triggerID" : "9adc0b3cda58cdb3cfd399326b5fefb3cbf69f20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5154)
* 9adc0b3cda58cdb3cfd399326b5fefb3cbf69f20 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5155)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a change in pull request #4574: [HUDI-3235] Fix ClassNotFoundException due to log4j-core dependency
Posted by GitBox <gi...@apache.org>.
yihua commented on a change in pull request #4574:
URL: https://github.com/apache/hudi/pull/4574#discussion_r783276616
##########
File path: hudi-sync/hudi-hive-sync/pom.xml
##########
@@ -154,7 +154,6 @@
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-core</artifactId>
- <version>2.17.0</version>
Review comment:
cool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4574: [HUDI-3235] Fix ClassNotFoundException due to log4j-core dependency
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4574:
URL: https://github.com/apache/hudi/pull/4574#issuecomment-1011246387
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5154",
"triggerID" : "3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb",
"triggerType" : "PUSH"
}, {
"hash" : "9adc0b3cda58cdb3cfd399326b5fefb3cbf69f20",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5155",
"triggerID" : "9adc0b3cda58cdb3cfd399326b5fefb3cbf69f20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9adc0b3cda58cdb3cfd399326b5fefb3cbf69f20 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5155)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4574: [HUDI-3235] Fix ClassNotFoundException due to log4j-core dependency
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4574:
URL: https://github.com/apache/hudi/pull/4574#issuecomment-1011167664
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4574: [HUDI-3235] Fix ClassNotFoundException due to log4j-core dependency
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4574:
URL: https://github.com/apache/hudi/pull/4574#issuecomment-1011170990
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5154",
"triggerID" : "3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5154)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4574: [HUDI-3235] Fix ClassNotFoundException due to log4j-core dependency
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4574:
URL: https://github.com/apache/hudi/pull/4574#issuecomment-1011167664
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4574: [HUDI-3235] Fix ClassNotFoundException due to log4j-core dependency
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4574:
URL: https://github.com/apache/hudi/pull/4574#issuecomment-1011170990
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5154",
"triggerID" : "3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5154)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4574: [HUDI-3235] Fix ClassNotFoundException due to log4j-core dependency
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4574:
URL: https://github.com/apache/hudi/pull/4574#issuecomment-1011187966
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5154",
"triggerID" : "3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb",
"triggerType" : "PUSH"
}, {
"hash" : "9adc0b3cda58cdb3cfd399326b5fefb3cbf69f20",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5155",
"triggerID" : "9adc0b3cda58cdb3cfd399326b5fefb3cbf69f20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3969fac27c4ccbdcbb8d0ddb47b735a2c4a909bb Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5154)
* 9adc0b3cda58cdb3cfd399326b5fefb3cbf69f20 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5155)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a change in pull request #4574: [HUDI-3235] Fix ClassNotFoundException due to log4j-core dependency
Posted by GitBox <gi...@apache.org>.
yihua commented on a change in pull request #4574:
URL: https://github.com/apache/hudi/pull/4574#discussion_r783263555
##########
File path: hudi-utilities/pom.xml
##########
@@ -489,5 +489,11 @@
<artifactId>junit-platform-commons</artifactId>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-core</artifactId>
+ <scope>test</scope>
Review comment:
Similar here.
##########
File path: hudi-sync/hudi-hive-sync/pom.xml
##########
@@ -154,7 +154,6 @@
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-core</artifactId>
- <version>2.17.0</version>
Review comment:
Do we want to set the log4j version here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #4574: [HUDI-3235] Fix ClassNotFoundException due to log4j-core dependency
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #4574:
URL: https://github.com/apache/hudi/pull/4574
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a change in pull request #4574: [HUDI-3235] Fix ClassNotFoundException due to log4j-core dependency
Posted by GitBox <gi...@apache.org>.
codope commented on a change in pull request #4574:
URL: https://github.com/apache/hudi/pull/4574#discussion_r783264977
##########
File path: hudi-sync/hudi-hive-sync/pom.xml
##########
@@ -154,7 +154,6 @@
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-core</artifactId>
- <version>2.17.0</version>
Review comment:
declared in top level pom which will be inherited here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org