You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "sarvekshayr (via GitHub)" <gi...@apache.org> on 2024/05/08 14:08:26 UTC
[PR] HDDS-10829. Suppress extra INFO log lines from ozone shell commands output [ozone]
sarvekshayr opened a new pull request, #6657:
URL: https://github.com/apache/ozone/pull/6657
## What changes were proposed in this pull request?
Changed the log level of the extra log lines from INFO to DEBUG.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10829
## How was this patch tested?
This patch was tested by running the ozone shell commands on docker.
(disabled the function `ozone_suppress_shell_log` for testing purpose)
Before suppressing the logs:
<img width="695" alt="Screenshot 2024-05-08 at 4 17 15 PM" src="https://github.com/apache/ozone/assets/79865743/27e04440-8fd4-4d89-adcc-811868471f10">
After suppressing the logs:
<img width="707" alt="Screenshot 2024-05-08 at 4 03 20 PM" src="https://github.com/apache/ozone/assets/79865743/13a6a184-ffd1-43ec-9f9b-77ecac41f9d7">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10829. Suppress extra INFO log lines from ozone shell commands output [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #6657:
URL: https://github.com/apache/ozone/pull/6657#discussion_r1595003760
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/client/ClientTrustManager.java:
##########
@@ -145,7 +145,7 @@ private void initialize(List<X509Certificate> caCerts)
private List<X509Certificate> loadCerts(CACertificateProvider caCertsProvider)
throws CertificateException {
try {
- LOG.info("Loading certificates for client.");
+ LOG.debug("Loading certificates for client.");
Review Comment:
@sarvekshayr `TestOzoneContainerWithTLS` needs to set log level for `ClientTrustManager` to `DEBUG`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10829. Suppress extra INFO log lines from ozone shell commands output [ozone]
Posted by "duongkame (via GitHub)" <gi...@apache.org>.
duongkame commented on PR #6657:
URL: https://github.com/apache/ozone/pull/6657#issuecomment-2103248185
Thanks @sarvekshayr for the patch and @adoroszlai for reviewing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10829. Suppress extra INFO log lines from ozone shell commands output [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #6657:
URL: https://github.com/apache/ozone/pull/6657#discussion_r1594578059
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/client/ClientTrustManager.java:
##########
@@ -145,7 +145,7 @@ private void initialize(List<X509Certificate> caCerts)
private List<X509Certificate> loadCerts(CACertificateProvider caCertsProvider)
throws CertificateException {
try {
- LOG.info("Loading certificates for client.");
+ LOG.debug("Loading certificates for client.");
Review Comment:
Looks like integration test is looking for this log message:
```
Error: Tests run: 6, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 11.809 s <<< FAILURE! - in org.apache.hadoop.ozone.container.ozoneimpl.TestOzoneContainerWithTLS
Error: org.apache.hadoop.ozone.container.ozoneimpl.TestOzoneContainerWithTLS.testLongLivingClientWithCertRenews Time elapsed: 0.857 s <<< FAILURE!
org.opentest4j.AssertionFailedError: Client loaded certificates. ==> expected: <true> but was: <false>
at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1156)
at org.apache.hadoop.ozone.container.ozoneimpl.TestOzoneContainerWithTLS.assertClientTrustManagerLoading(TestOzoneContainerWithTLS.java:288)
at org.apache.hadoop.ozone.container.ozoneimpl.TestOzoneContainerWithTLS.testLongLivingClientWithCertRenews(TestOzoneContainerWithTLS.java:229)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10829. Suppress extra INFO log lines from ozone shell commands output [ozone]
Posted by "duongkame (via GitHub)" <gi...@apache.org>.
duongkame merged PR #6657:
URL: https://github.com/apache/ozone/pull/6657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org