[jira] [Issue Comment Deleted] (CALCITE-3782) Bitwise operator Bit_And, Bit_OR and Bit_XOR support binary and varbinary type

["Vladimir Sitnikov (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vladimir Sitnikov updated CALCITE-3782:
---------------------------------------
    Comment: was deleted

(was: Ok, it seems there's a bug in javadoc. It says the return value is nullable, however the code is using it without null-checks all over the place. All the default implementations in Calcite return non-nullable value.

{code:java}
public interface RelDataType {
  /**
   * Gets the {@link SqlTypeName} of this type.
   *
   * @return SqlTypeName, or null if this is not an SQL predefined type
   */
  @Nullable SqlTypeName getSqlTypeName();
{code}

Typical use site:

{code:java}
switch (toType.getSqlTypeName()) {
{code}

What if we update the javadoc and specify the return value should be non-nullable?
)

> Bitwise operator Bit_And, Bit_OR and Bit_XOR support binary and varbinary type
> ------------------------------------------------------------------------------
>
>                 Key: CALCITE-3782
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3782
>             Project: Calcite
>          Issue Type: Sub-task
>          Components: core
>    Affects Versions: 1.22.0
>            Reporter: hailong wang
>            Assignee: hailong wang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.26.0
>
>          Time Spent: 4h 50m
>  Remaining Estimate: 0h
>
> According to the discussion  link CALCITE-3732 , We should make bitwise operators work on all integer types, BINARY and VARBINARY. So Bit_And, Bit_OR and Bit_XOR agg operator should also support BINARY and VARBINARY.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)