[GitHub] [airflow] pateash commented on a change in pull request #21076: [WIP]: Add GitHub provider

[GitBox <gi...@apache.org>]

pateash commented on a change in pull request #21076:
URL: https://github.com/apache/airflow/pull/21076#discussion_r791867823



##########
File path: airflow/providers/github/hooks/github.py
##########
@@ -0,0 +1,77 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""This module allows to connect to a Github."""
+
+from typing import Dict
+
+from github import Github as GithubClient, PaginatedList
+
+from airflow.hooks.base import BaseHook
+
+
+class GithubHook(BaseHook):
+    """
+    Interact with Github.
+
+    Performs a connection to Github and retrieves client.
+
+    :param github_conn_id: Reference to :ref:`Github connection id <howto/connection:github>`.
+    :type github_conn_id: str
+    """
+
+    conn_name_attr = 'github_conn_id'
+    default_conn_name = 'github_default'
+    conn_type = 'github'
+    hook_name = 'Github'
+
+    def __init__(self, github_conn_id: str = default_conn_name, *args, **kwargs) -> None:
+        super().__init__(*args, **kwargs)
+        self.connection = None
+        self.github_conn_id = github_conn_id
+        self.client = None
+        self.get_conn()
+
+    def get_conn(self) -> GithubClient:
+        """
+        Function that initiates a new Github connection
+        with token and hostname name
+        """
+        if self.client is not None:
+            return self.client
+
+        self.connection = self.get_connection(self.github_conn_id)
+        access_token = self.connection.password
+
+        self.client = GithubClient(login_or_token=access_token)
+        return self.client
+
+    @staticmethod
+    def get_ui_field_behaviour() -> Dict:
+        """Returns custom field behaviour"""
+        return {
+            "hidden_fields": ['schema', 'port', 'host', 'login', 'extra'],
+            "relabeling": {
+                # 'host': 'Github Enterprise Url',

Review comment:
       for Github Enterprise we have to provide host url,
   I am thinking of adding Github Enterprise support in next release with new connection for GithubEnterprise, 
   What do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org