You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/01 00:07:28 UTC

[GitHub] [arrow] kou commented on a diff in pull request #13486: ARROW-16936: [C++] Update gRPC absl static dependencies

kou commented on code in PR #13486:
URL: https://github.com/apache/arrow/pull/13486#discussion_r911523929


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -3834,7 +3834,55 @@ macro(build_grpc)
 
   list(APPEND
        ARROW_BUNDLED_STATIC_LIBS
-       ${GRPC_GPR_ABSL_LIBRARIES}
+       # This list of absl dependencies can be generated with:
+       # pkg-config --libs --static grpc \
+       #   | tr " " "\n" \
+       #   | grep ^-labsl_ \
+       #   | sed 's/^-labsl_/absl::/'

Review Comment:
   Why did you replace `${GRPC_GPR_ABSL_LIBRARIES}` instead of updating `set(GRPC_GPR_ABSL_LIBRARIES ...)`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org