You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "peterxcli (via GitHub)" <gi...@apache.org> on 2025/08/30 20:26:46 UTC

[PR] HDDS-13484. Replace goofys in Ozone CSI [ozone]

peterxcli opened a new pull request, #8987:
URL: https://github.com/apache/ozone/pull/8987

   ## What changes were proposed in this pull request?
   
   Once the latest ozone docker runner release has the mountpoint-s3 binaries, we can replace goofys in Ozone CSI service:
   
   https://github.com/peterxcli/ozone/blob/7481fe9aeafb85f6023d62a6e023035b9cb34605/hadoop-ozone/csi/src/main/java/org/apache/hadoop/ozone/csi/CsiServer.java#L133
   
   We also need to update the user doc to reflect the change: https://github.com/peterxcli/ozone/blob/cb0a402bea59da76fe51c51cd61ab4bfe99417cb/hadoop-hdds/docs/content/interface/CSI.md#L29
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-13484
   
   ## How was this patch tested?
   
   (Please explain how this patch was tested. Ex: unit tests, manual tests, workflow run on the fork git repo.)
   (If this patch involves UI changes, please attach a screenshot; otherwise, remove this.)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-13484. Replace goofys in Ozone CSI [ozone]

Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on PR #8987:
URL: https://github.com/apache/ozone/pull/8987#issuecomment-3240835583

   @adoroszlai  this is going to require a new docker runner release that include the mountpoint-s3 binaries.
   We'll also need to update the docker runner image version in the code to test using the new image.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-13484. Replace goofys with mountpoint-s3 in Ozone CSI [ozone]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8987:
URL: https://github.com/apache/ozone/pull/8987#issuecomment-3573218538

   Thank you for your contribution. This PR is being closed due to inactivity. If needed, feel free to reopen it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-13484. Replace goofys with mountpoint-s3 in Ozone CSI [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #8987:
URL: https://github.com/apache/ozone/pull/8987#issuecomment-3265041810

   > this is going to require a new docker runner release that include the mountpoint-s3 binaries.
   
   Image version `20250718-1-jdk21` includes mountpoint-s3.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-13484. Replace goofys in Ozone CSI [ozone]

Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on code in PR #8987:
URL: https://github.com/apache/ozone/pull/8987#discussion_r2312839553


##########
hadoop-ozone/csi/pom.xml:
##########
@@ -81,6 +81,10 @@
       <groupId>io.grpc</groupId>
       <artifactId>grpc-stub</artifactId>
     </dependency>
+    <dependency>
+      <groupId>io.netty</groupId>

Review Comment:
   wonder why this is required only now.



##########
hadoop-ozone/csi/src/main/java/org/apache/hadoop/ozone/csi/CsiServer.java:
##########
@@ -57,33 +57,93 @@ public Void call() throws Exception {
             CsiServer.class, originalArgs, LOG, ozoneConfiguration);
     CsiConfig csiConfig = ozoneConfiguration.getObject(CsiConfig.class);
 
-    OzoneClient rpcClient = OzoneClientFactory.getRpcClient(ozoneConfiguration);
+    validateConfiguration(csiConfig);
 
-    EpollEventLoopGroup group = new EpollEventLoopGroup();
+    OzoneClient rpcClient = null;
+    EpollEventLoopGroup group = null;
+    Server server = null;
 
+    try {
+      rpcClient = OzoneClientFactory.getRpcClient(ozoneConfiguration);
+      group = new EpollEventLoopGroup();
+
+      server = buildGrpcServer(csiConfig, rpcClient, group);
+
+      server.start();
+      LOG.info("CSI server started successfully on socket: {}",
+          csiConfig.getSocketPath());
+
+      addShutdownHook(server, rpcClient, group);
+
+      server.awaitTermination();
+    } catch (Exception e) {
+      LOG.error("Error starting CSI server", e);
+      cleanup(server, rpcClient, group);

Review Comment:
   i think we want to close rpcClient regardless of exception or not.
   (can w put cleanup() in the finally {} block?)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-13484. Replace goofys with mountpoint-s3 in Ozone CSI [ozone]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8987:
URL: https://github.com/apache/ozone/pull/8987#issuecomment-3514417442

   This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-13484. Replace goofys with mountpoint-s3 in Ozone CSI [ozone]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #8987: HDDS-13484. Replace goofys with mountpoint-s3 in Ozone CSI
URL: https://github.com/apache/ozone/pull/8987


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org