[GitHub] [hbase] taklwu commented on a change in pull request #2441: HBASE-25085 Add support for java properties to hbase-vote.sh

[GitBox <gi...@apache.org>]

taklwu commented on a change in pull request #2441:
URL: https://github.com/apache/hbase/pull/2441#discussion_r495227241



##########
File path: dev-support/hbase-vote.sh
##########
@@ -164,11 +167,11 @@ function print_when_exit() {
         * Signature: $( ((SIGNATURE_PASSED)) && echo "ok" || echo "failed" )
         * Checksum : $( ((CHECKSUM_PASSED)) && echo "ok" || echo "failed" )
         * Rat check (${JAVA_VERSION}): $( ((RAT_CHECK_PASSED)) && echo "ok" || echo "failed" )
-         - mvn clean apache-rat:check
+         - mvn clean apache-rat:check "${MVN_PROPERTIES}"
         * Built from source (${JAVA_VERSION}): $( ((BUILD_FROM_SOURCE_PASSED)) && echo "ok" || echo "failed" )
-         - mvn clean install -DskipTests
+         - mvn clean install -DskipTests "${MVN_PROPERTIES}"
         * Unit tests pass (${JAVA_VERSION}): $( ((UNIT_TEST_PASSED)) && echo "ok" || echo "failed" )
-         - mvn package ${MVN_ARGS}
+         - mvn package ${MVN_PROFILES} "${MVN_PROPERTIES}"

Review comment:
       [nit] should we add `-Dsurefire.rerunFailingTestsCount=3` as part of the output? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org