[GitHub] [incubator-superset] john-bodley edited a comment on issue #8175: [metric] Exposing security methods for visualizations and query-context

[GitBox <gi...@apache.org>]

john-bodley edited a comment on issue #8175: [metric] Exposing security methods for visualizations and query-context
URL: https://github.com/apache/incubator-superset/pull/8175#issuecomment-531035257
 
 
   @mistercrunch thanks for deprecating the restricted metrics (as a side note I wonder if there should be another migration to remove all the obsolete `metric_access` permissions). 
   
   I've updated the PR which removes the now obsolete metric checks. Are you still supportive of having the:
   
   - `assert_query_context_permission`
   - `assert_viz_permission`
   
   methods which now have the same behavior as the datasource access but simply provide more context, i.e., the fully defined current context, if a custom security manager would like to override. 
   
   Let me know how best to proceed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org