You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/22 01:07:00 UTC

[GitHub] [airflow] iameugenejo edited a comment on pull request #14212: fix type mismatch of max_retry_delay

iameugenejo edited a comment on pull request #14212:
URL: https://github.com/apache/airflow/pull/14212#issuecomment-782971311


   > > I honestly do not know where this `max_retry_delay` in `timedelta` type gets reassigned as a `float`. so please close this PR if someone finds the code that does that and fix it there as a permanent solution
   > 
   > Max retry delay is taken from what ever the DAG author puts in their ctor args
   
   That's what I thought, and I have every dag with the max_retry_delay set with timedelta value, and the scheduler still fails to start someteimes because this value gets converted to float at some point. My guess is that it must be happening for dynamic dags. I currently have no time to make this change formalized with testing or find the cause of such conversion. I'll make the deployment of my environment with this patch locally until someone else has time to debug and find the real cause of this. You can close this PR if you'd like.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org