You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by tinkoff-dwh <gi...@git.apache.org> on 2017/05/02 16:09:04 UTC
[GitHub] zeppelin pull request #2309: [ZEPPELIN-2482] added font size for paragraph
GitHub user tinkoff-dwh opened a pull request:
https://github.com/apache/zeppelin/pull/2309
[ZEPPELIN-2482] added font size for paragraph
### What is this PR for?
1. Added possibilty to change font size of paragraph text
2. Fixed cloneParagraphAction (immediately after the cloning is incorrectly displayed a new paragraph)
3. Fixed paragraph settings into Firefox
### What type of PR is it?
Feature
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2482
### How should this be tested?
1. Open note
2. Add some text to paragraph
3. Open settings of paragraph and chenge "Font size"
### Screenshots (if appropriate)
1. Font size and clone
BEFORE
AFTER
2. Fix for Firefox
BEFORE
AFTER
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2482
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2309.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2309
----
commit 5e2be167d5a532e7d9522bdedee1c5cde360be66
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-02T11:18:04Z
[ZEPPELIN-2482] font size for paragraph
commit 794bbf1b10e7926dd5917bdd727b4245630b9255
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-02T12:34:49Z
[ZEPPELIN-2482] close settings
commit 62ef72860dde7c7b50e6b15043fea9ef38884bd9
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-02T15:32:07Z
[ZEPPELIN-2482] font size test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2309
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2309
In `Font size and clone` and firefox browser case, I tested and it's work well. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2309
@1ambda
no, thx. it's clear
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2309
I'll merge it if there's no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2309
[ZEPPELIN-2482] added font size for paragraph
### What is this PR for?
1. Added possibilty to change font size of paragraph text
2. Fixed cloneParagraphAction (immediately after the cloning is incorrectly displayed a new paragraph)
3. Fixed paragraph settings into Firefox
### What type of PR is it?
Feature
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2482
### How should this be tested?
1. Open note
2. Add some text to paragraph
3. Open settings of paragraph and chenge "Font size"
### Screenshots (if appropriate)
1. Font size and clone
BEFORE
AFTER
2. Fix for Firefox
BEFORE
AFTER
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2482
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2309.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2309
----
commit 5e2be167d5a532e7d9522bdedee1c5cde360be66
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-02T11:18:04Z
[ZEPPELIN-2482] font size for paragraph
commit 794bbf1b10e7926dd5917bdd727b4245630b9255
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-02T12:34:49Z
[ZEPPELIN-2482] close settings
commit 62ef72860dde7c7b50e6b15043fea9ef38884bd9
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-02T15:32:07Z
[ZEPPELIN-2482] font size test
commit 42135ad078dce603de57fd17c975c1dcb3121611
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-15T07:47:31Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2482
commit fea747097c243a21f077994271ccc2318384a120
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-12T10:43:50Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2482
commit a8aa65ded60b78ff8374d47379e5e7a4c6f9d12a
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-12T11:13:10Z
Merge remote-tracking branch 'origin/ZEPPELIN-2482' into ZEPPELIN-2482
commit 5b92b285628f838f6971a997de59ebdb12a4be9b
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-12T17:11:32Z
[ZEPPELIN-2482] broadcast changes of fontSize
commit 0197fd16bafcc7f4f202821bf95aadf26104a62d
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-14T09:15:36Z
[ZEPPELIN-2482] fix selenium tests
commit abf9e4520a309188e1c55dc63e774f4d5218f9dc
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-14T09:38:58Z
[ZEPPELIN-2482] fix selenium tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2309
@1ambda
save changes by change font size works fine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2309
@jongyoul
?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2309
@1ambda
can you provide a link to the code where it is implemented to **colWidth**?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2309
I attached a GIF.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2309
the same errors
```
ParagraphActionsIT.testSingleDynamicFormSelectForm:624 » NoSuchElement Cannot ...
ParagraphActionsIT.testMultipleDynamicFormsSameType:707 » NoSuchElement Cannot...
ParagraphActionsIT.testRunOnSelectionChange:282 » NoSuchElement Cannot locate ...
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2309
[ZEPPELIN-2482] added font size for paragraph
### What is this PR for?
1. Added possibilty to change font size of paragraph text
2. Fixed cloneParagraphAction (immediately after the cloning is incorrectly displayed a new paragraph)
3. Fixed paragraph settings into Firefox
### What type of PR is it?
Feature
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2482
### How should this be tested?
1. Open note
2. Add some text to paragraph
3. Open settings of paragraph and chenge "Font size"
### Screenshots (if appropriate)
1. Font size and clone
BEFORE
AFTER
2. Fix for Firefox
BEFORE
AFTER
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2482
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2309.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2309
----
commit 5e2be167d5a532e7d9522bdedee1c5cde360be66
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-02T11:18:04Z
[ZEPPELIN-2482] font size for paragraph
commit 794bbf1b10e7926dd5917bdd727b4245630b9255
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-02T12:34:49Z
[ZEPPELIN-2482] close settings
commit 62ef72860dde7c7b50e6b15043fea9ef38884bd9
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-02T15:32:07Z
[ZEPPELIN-2482] font size test
commit 42135ad078dce603de57fd17c975c1dcb3121611
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-15T07:47:31Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2482
commit fea747097c243a21f077994271ccc2318384a120
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-12T10:43:50Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2482
commit a8aa65ded60b78ff8374d47379e5e7a4c6f9d12a
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-12T11:13:10Z
Merge remote-tracking branch 'origin/ZEPPELIN-2482' into ZEPPELIN-2482
commit 5b92b285628f838f6971a997de59ebdb12a4be9b
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-12T17:11:32Z
[ZEPPELIN-2482] broadcast changes of fontSize
commit 0197fd16bafcc7f4f202821bf95aadf26104a62d
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-14T09:15:36Z
[ZEPPELIN-2482] fix selenium tests
commit abf9e4520a309188e1c55dc63e774f4d5218f9dc
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-14T09:38:58Z
[ZEPPELIN-2482] fix selenium tests
commit 119a67a7c3df4d85efa040c906d3e9da8d3b2879
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-16T05:53:33Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2482
# Conflicts:
# zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2309
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2309
This feature will be helpful when displaying in the report mode but want to increase font-size.
- need to be rebased. base branch is outdated.
- *+1* reindent DOMs and having a test
LGTM. Thanks for the contribution @tinkoff-dwh.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2309
thx for review.
@jongyoul
can you init merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2309
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2309
@tinkoff-dwh @jongyoul sorry for the late reply.
I will test and comment in few hours.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2309
Thanks @tinkoff-dwh and nice feature!
Let me test and come back here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2309
@tinkoff-dwh Do you still need a link? or just wanted to check the behavior?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2309
CI red -> AuthenticationIT.testGroupPermission
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2309
sorry it is my fault. i added new dropdown menu (font size) so order of elements (select) is changed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2309
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2309
@1ambda Thanks. @tinkoff-dwh Please catch up the comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2309
Missed. I'll merge it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2309
@tinkoff-dwh saving works. but it's not automatically propagated to other web-browsers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2309
Looks good. I guess the failed job in https://travis-ci.org/tinkoff-dwh/zeppelin/builds/242104908 is due to a flaky test. But just to make sure, could you restart it so that CI will be green?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2309
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2309
@1ambda
done
ci red because fall other tests (not mine)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2309
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2309
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2309
LGTM. @1ambda Can you verify it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---