You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Alex Vigdor (JIRA)" <ji...@apache.org> on 2010/01/05 22:16:18 UTC

[jira] Created: (SANSELAN-35) IPTCParser fails after encountering record number 1

IPTCParser fails after encountering record number 1
---------------------------------------------------

                 Key: SANSELAN-35
                 URL: https://issues.apache.org/jira/browse/SANSELAN-35
             Project: Commons Sanselan
          Issue Type: Bug
            Reporter: Alex Vigdor
            Priority: Minor


IPTCParser fails to find valid metadata in a JPEG after it encounters a record number 1 (it only extracts metadata from records numbered 2).  A little debugging showed that this is because it was not properly moving the buffer pointer to the end of the record to pick up subsequent valid records - moving the record number check after the pointer update fixes the problem.  I will attach a patch and sample image.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SANSELAN-35) IPTCParser fails after encountering record number 1

Posted by "Alex Vigdor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SANSELAN-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Vigdor updated SANSELAN-35:
--------------------------------

    Attachment: SANSELAN-35.patch
                2010-01-04T052300Z_01_BTRE6021PS000_RTROPTP_3_BUSINESS-US-TSE.JPG

The JPG file demonstrates the bug - use ImageMagick, Photoshop or an other tool and see valid IPTC metadata, but Sanselan misses it.  After applying the attached patch, Sanselan does find the metadata in the JPG.

> IPTCParser fails after encountering record number 1
> ---------------------------------------------------
>
>                 Key: SANSELAN-35
>                 URL: https://issues.apache.org/jira/browse/SANSELAN-35
>             Project: Commons Sanselan
>          Issue Type: Bug
>            Reporter: Alex Vigdor
>            Priority: Minor
>         Attachments: 2010-01-04T052300Z_01_BTRE6021PS000_RTROPTP_3_BUSINESS-US-TSE.JPG, SANSELAN-35.patch
>
>
> IPTCParser fails to find valid metadata in a JPEG after it encounters a record number 1 (it only extracts metadata from records numbered 2).  A little debugging showed that this is because it was not properly moving the buffer pointer to the end of the record to pick up subsequent valid records - moving the record number check after the pointer update fixes the problem.  I will attach a patch and sample image.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.