[GitHub] [flink] wangxlong commented on a change in pull request #10144: [FLINK-14613][table-planner-blink] Fix temporal table join when containing multiple keyfields with UDF

[GitBox <gi...@apache.org>]

wangxlong commented on a change in pull request #10144: [FLINK-14613][table-planner-blink] Fix temporal table join when containing multiple keyfields with UDF
URL: https://github.com/apache/flink/pull/10144#discussion_r347126628
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/common/CommonLookupJoin.scala
 ##########
 @@ -419,19 +419,17 @@ abstract class CommonLookupJoin(
       joinKeyPairs: Array[IntPair],
       joinInfo: JoinInfo,
       allLookupKeys: Map[Int, LookupKey]): Option[RexNode] = {
-    val remainingPairs = joinKeyPairs.filter(p => !checkedLookupFields.contains(p.target))
+    val joinPairs = joinInfo.pairs().asScala.toArray
+    val remainingPairs = joinPairs.filter(p => !checkedLookupFields.contains(p.target))
 
 Review comment:
   Thank you. This help me a lot. I have fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services