You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhishek Kumar <ab...@gmail.com> on 2022/04/25 03:18:58 UTC
Review Request 73957: Restructure ranger Dockerfile to use multi-stage builds
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73957/
-----------------------------------------------------------
Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Repository: ranger
Description
-------
Dockerfiles with multi-stage builds are more optimized and easy to maintain.(for ex: useful for adding additonal db support in ranger docker in an optimized way)
Link: https://docs.docker.com/develop/develop-images/multistage-build/
Diffs
-----
dev-support/ranger-docker/Dockerfile.ranger b11e72666
Diff: https://reviews.apache.org/r/73957/diff/1/
Testing
-------
Tested locally.
Thanks,
Abhishek Kumar
Re: Review Request 73957: Restructure ranger Dockerfile to use multi-stage builds
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73957/#review224371
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On April 25, 2022, 3:18 a.m., Abhishek Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73957/
> -----------------------------------------------------------
>
> (Updated April 25, 2022, 3:18 a.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Dockerfiles with multi-stage builds are more optimized and easy to maintain.(for ex: useful for adding additonal db support in ranger docker in an optimized way)
> Link: https://docs.docker.com/develop/develop-images/multistage-build/
>
>
> Diffs
> -----
>
> dev-support/ranger-docker/Dockerfile.ranger b11e72666
>
>
> Diff: https://reviews.apache.org/r/73957/diff/1/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Abhishek Kumar
>
>
Re: Review Request 73957: RANGER-3738: Restructure ranger Dockerfile to use multi-stage builds
Posted by Abhishek Kumar <ab...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73957/
-----------------------------------------------------------
(Updated April 28, 2022, 5:46 p.m.)
Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Summary (updated)
-----------------
RANGER-3738: Restructure ranger Dockerfile to use multi-stage builds
Bugs: RANGER-3738
https://issues.apache.org/jira/browse/RANGER-3738
Repository: ranger
Description
-------
Dockerfiles with multi-stage builds are more optimized and easy to maintain.(for ex: useful for adding additonal db support in ranger docker in an optimized way)
Link: https://docs.docker.com/develop/develop-images/multistage-build/
Diffs
-----
dev-support/ranger-docker/Dockerfile.ranger b11e72666
Diff: https://reviews.apache.org/r/73957/diff/1/
Testing
-------
Tested locally.
Thanks,
Abhishek Kumar
Re: Review Request 73957: Restructure ranger Dockerfile to use multi-stage builds
Posted by Abhishek Kumar <ab...@gmail.com>.
> On April 26, 2022, 8:46 p.m., Madhan Neethiraj wrote:
> > Does this require any changes to instructions in README.txt?
No, it does not.
- Abhishek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73957/#review224372
-----------------------------------------------------------
On April 25, 2022, 3:18 a.m., Abhishek Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73957/
> -----------------------------------------------------------
>
> (Updated April 25, 2022, 3:18 a.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Dockerfiles with multi-stage builds are more optimized and easy to maintain.(for ex: useful for adding additonal db support in ranger docker in an optimized way)
> Link: https://docs.docker.com/develop/develop-images/multistage-build/
>
>
> Diffs
> -----
>
> dev-support/ranger-docker/Dockerfile.ranger b11e72666
>
>
> Diff: https://reviews.apache.org/r/73957/diff/1/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Abhishek Kumar
>
>
Re: Review Request 73957: Restructure ranger Dockerfile to use multi-stage builds
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73957/#review224372
-----------------------------------------------------------
Ship it!
Does this require any changes to instructions in README.txt?
- Madhan Neethiraj
On April 25, 2022, 3:18 a.m., Abhishek Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73957/
> -----------------------------------------------------------
>
> (Updated April 25, 2022, 3:18 a.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Dockerfiles with multi-stage builds are more optimized and easy to maintain.(for ex: useful for adding additonal db support in ranger docker in an optimized way)
> Link: https://docs.docker.com/develop/develop-images/multistage-build/
>
>
> Diffs
> -----
>
> dev-support/ranger-docker/Dockerfile.ranger b11e72666
>
>
> Diff: https://reviews.apache.org/r/73957/diff/1/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Abhishek Kumar
>
>