You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/07 02:56:32 UTC

[GitHub] [pulsar] codelipenghui commented on a change in pull request #11937: Avoid to infinitely split bundle

codelipenghui commented on a change in pull request #11937:
URL: https://github.com/apache/pulsar/pull/11937#discussion_r703141942



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/BundleSplitterTask.java
##########
@@ -82,6 +82,11 @@ public BundleSplitterTask(final PulsarService pulsar) {
                     totalMessageRate = longTermData.totalMsgRate();
                     totalMessageThroughput = longTermData.totalMsgThroughput();
                 }
+                // if there are just one topic, avoid to infinitely split
+                if (stats.topics == 1) {

Review comment:
       Could you please help add a test for covering the new change?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org