[GitHub] [tvm] mherkazandjian commented on a change in pull request #7776: [CI] docker images build script cmd line args optional

[GitBox <gi...@apache.org>]

mherkazandjian commented on a change in pull request #7776:
URL: https://github.com/apache/tvm/pull/7776#discussion_r606326047



##########
File path: docker/README.md
##########
@@ -76,14 +77,39 @@ You can also start an interactive session by typing
 ./docker/build.sh image_name -it bash
 ```
 
+The built docker images are prefixed by ``tvm.``, for example the command
+
+````bash
+./docker/build.sh image_name 
+````
+
+produced the image ``tvm.ci_cpu`` that is displayed in the list of docker images

Review comment:
       done

##########
File path: docker/build.sh
##########
@@ -18,11 +18,11 @@
 # under the License.
 
 #
-# Execute command within a docker container
+# Build a docker container and optionally execute command within a it
 #
 # Usage: build.sh <CONTAINER_TYPE> [--tag <DOCKER_IMAGE_TAG>]
 #                [--dockerfile <DOCKERFILE_PATH>] [-it]
-#                [--net=host] [--cache-from <IMAGE_NAME>] <COMMAND>
+#                [--net=host] [--cache-from <IMAGE_NAME>] <COMMAND (optional)>

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org