You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/22 21:14:02 UTC
[GitHub] [airflow] john-jac commented on a change in pull request #19173: Add Note to SLA regarding schedule_interval
john-jac commented on a change in pull request #19173:
URL: https://github.com/apache/airflow/pull/19173#discussion_r734846593
##########
File path: docs/apache-airflow/concepts/tasks.rst
##########
@@ -163,6 +163,10 @@ If you want to disable SLA checking entirely, you can set ``check_slas = False``
To read more about configuring the emails, see :doc:`/howto/email-config`.
+.. note::
+
+ Only scheduled tasks, in a DAG with a valid ``schedule_interval``, will be checked against SLA. For more information on ``schedule_interval`` values, see :doc:`DAG Run </dag-run>`.
Review comment:
> `schedule_interval=None` is also "valid" so this is not strictly accurate. I think it is sufficient to just say "scheduled tasks" (since no runs would be scheduled with `schedule_interval=None`). Or, if you want to be explicit, add something like _For example, a DAG with `schedule_interval=None` will neve trigger SLA since no scheduled runs would ever be made_.
I'll make that change as well to be explicit. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org