You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2018/06/28 17:48:38 UTC
[GitHub] spark pull request #21659: [SPARK-24530][PYTHON] Add a control to force Pyth...
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21659#discussion_r198928988
--- Diff: python/docs/Makefile ---
@@ -1,19 +1,36 @@
# Makefile for Sphinx documentation
#
+# You can set this variable from command line to force Sphinx to use the Python executable.
+SPHINXPYTHON ?= python
+
+ifndef SPHINXBUILD
+# Note that there is an issue with Python version and Sphinx in PySpark documentation generation.
+# Please remove this check below when this issue is fixed. See SPARK-24530 for more details.
+PYTHON_VERSION_CHECK = $(shell $(SPHINXPYTHON) -c 'import sys; print(sys.version_info < (3, 0, 0))')
+ifeq ($(PYTHON_VERSION_CHECK), True)
+$(warning Note that Python 3 is required to generate PySpark documentation correctly for now. Current Python executable was less then Python 3. See SPARK-24530. To force Sphinx to use a specific Python executable, please set SPHINXPYTHON to point to the Python 3 executable.)
--- End diff --
`less then` -> `less than`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org