[jira] [Resolved] (SOLR-2819) Wrong isHex()-method in HTMLStripCharFilter

["Hoss Man (Resolved) (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man resolved SOLR-2819.
----------------------------

       Resolution: Fixed
    Fix Version/s: 4.0
                   3.6
         Assignee: Hoss Man

Nice catch Bernhard!

I think this is a new record for "time between bug introduced in code and bug reported" ... from what i can tell this has been in there since Solr 1.0 (but as you point out, didn't actually cause bad behavior since the final integer parsing would result in a MISMATCH and backtracking.

Still good to fix it though -- thank you for reporting it.

Committed revision 1208032. - trunk
Committed revision 1208037. - 3x


                
> Wrong isHex()-method in HTMLStripCharFilter
> -------------------------------------------
>
>                 Key: SOLR-2819
>                 URL: https://issues.apache.org/jira/browse/SOLR-2819
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 3.4
>            Reporter: Bernhard Berger
>            Assignee: Hoss Man
>            Priority: Trivial
>             Fix For: 3.6, 4.0
>
>
> In org.apache.solr.analysis HTMLStripCharFilter use a wrong isHex()-method that return characters like 'X', 'Y' as valid hex chars:
> {code}
>   private boolean isHex(int ch) {
>     return (ch>='0' && ch<='9') ||
>            (ch>='A' && ch<='Z') ||
>            (ch>='a' && ch<='z');
>   }
> {code}
> If only characters from [0-9a-zA-Z] are allowed, the readNumericEntity method will detect faster a mismatch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org