You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "jroachgolf84 (via GitHub)" <gi...@apache.org> on 2026/05/25 02:15:03 UTC

Re: [PR] Databricks: Fail fast for non-serializable retry_args in deferrable operators and triggers [airflow]

jroachgolf84 commented on code in PR #64960:
URL: https://github.com/apache/airflow/pull/64960#discussion_r3295774467


##########
providers/databricks/tests/unit/databricks/_retry_test_utils.py:
##########


Review Comment:
   Is this a common pattern that's used in other providers?



##########
providers/databricks/src/airflow/providers/databricks/triggers/databricks.py:
##########
@@ -53,6 +54,7 @@ def __init__(
         caller: str = "DatabricksExecutionTrigger",
     ) -> None:
         super().__init__()
+        validate_deferrable_databricks_retry_args(retry_args, owner=caller)

Review Comment:
   Are you treating this like a "gate keeper" of sorts? If the function fails, the class instantiation fails? I don't know if I love that pattern?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org