You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/29 16:06:32 UTC
[GitHub] [pulsar-client-go] ttys3 opened a new pull request, #819: [go]: reduce dependency
ttys3 opened a new pull request, #819:
URL: https://github.com/apache/pulsar-client-go/pull/819
### Motivation
currently we have `github.com/spf13/cobra v1.2` dependency, which depends on `spf13/viper` (which is a heavy mod)
the good news is that github.com/spf13/cobra version >= v1.4.0 has `viper` mod dependency removed.
yes, but we can still avoid introduce unnecessary dependency to SDK client users.
### Modifications
make the `pulsar-perf` binary a standalone mod, so that its `cobra` dependency does not affect pulsar-client-go
nothing is break, but a more clean go mod
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes)
Dependencies removed from module `github.com/apache/pulsar-client-go`:
```go
github.com/bmizerany/perks v0.0.0-20141205001514-d9a9656a3a4b
github.com/spf13/cobra v1.2.1
```
new module `github.com/apache/pulsar-client-go/pulsar-perf` introduced (which is not a package, but binary only package)
old `github.com/spf13/cobra v1.2.1` updated to `github.com/spf13/cobra v1.5.0` since this version has `github.com/spf13/viper` removed (which does not affect the feature of cobra, see https://github.com/spf13/cobra/releases/tag/v1.4.0 )
```go
github.com/apache/pulsar-client-go v0.8.1
github.com/bmizerany/perks v0.0.0-20141205001514-d9a9656a3a4b
github.com/prometheus/client_golang v1.12.2
github.com/sirupsen/logrus v1.9.0
github.com/spf13/cobra v1.5.0
```
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] ttys3 commented on pull request #819: [go]: reduce dependency
Posted by GitBox <gi...@apache.org>.
ttys3 commented on PR #819:
URL: https://github.com/apache/pulsar-client-go/pull/819#issuecomment-1273991805
@zzzming rebased, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org