You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2017/10/11 10:12:59 UTC

[GitHub] flink pull request #4797: [hotfix][doc] Remove outdated best-practice sugges...

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/4797

    [hotfix][doc] Remove outdated best-practice suggestion to use .withParameters()

    This way of passing parameters does not work with the streaming API and
    is actually confusing for users.
    
    R: @zentol 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4797.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4797
    
----
commit c7825b88d3191574bee9b8aad3113e605bd5f6e9
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2017-10-11T10:10:13Z

    [hotfix][doc] Remove outdated best-practice suggestion to use .withParameters()
    
    This way of passing parameters does not work with the streaming API and
    is actually confusing for users.

----


---

[GitHub] flink pull request #4797: [hotfix][doc] Remove outdated best-practice sugges...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4797


---

[GitHub] flink issue #4797: [hotfix][doc] Remove outdated best-practice suggestion to...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4797
  
    +1


---

[GitHub] flink issue #4797: [hotfix][doc] Remove outdated best-practice suggestion to...

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/4797
  
    Thanks! 👌 


---

[GitHub] flink issue #4797: [hotfix][doc] Remove outdated best-practice suggestion to...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4797
  
    merging.


---