You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/12/13 22:51:07 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4925:
Refactor Predicate classes and make them easier to use
codecov-io edited a comment on issue #4925: Refactor Predicate classes and make them easier to use
URL: https://github.com/apache/incubator-pinot/pull/4925#issuecomment-565638273
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4925?src=pr&el=h1) Report
> Merging [#4925](https://codecov.io/gh/apache/incubator-pinot/pull/4925?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/acaa78d3358a56004a54c6b220587d6d47fe38c3?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `85.91%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4925?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4925 +/- ##
============================================
+ Coverage 56.54% 56.58% +0.03%
Complexity 53 53
============================================
Files 1177 1177
Lines 62894 62839 -55
Branches 9231 9219 -12
============================================
- Hits 35566 35556 -10
+ Misses 24688 24650 -38
+ Partials 2640 2633 -7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4925?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lter/predicate/RangePredicateEvaluatorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4925/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvcHJlZGljYXRlL1JhbmdlUHJlZGljYXRlRXZhbHVhdG9yRmFjdG9yeS5qYXZh) | `89.88% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/pinot/common/utils/request/RequestUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4925/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvcmVxdWVzdC9SZXF1ZXN0VXRpbHMuamF2YQ==) | `85.23% <ø> (-0.1%)` | `0 <0> (ø)` | |
| [...r/filter/predicate/PredicateEvaluatorProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4925/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvcHJlZGljYXRlL1ByZWRpY2F0ZUV2YWx1YXRvclByb3ZpZGVyLmphdmE=) | `56.52% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...inot/core/operator/filter/FilterOperatorUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4925/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvRmlsdGVyT3BlcmF0b3JVdGlscy5qYXZh) | `84.84% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...core/operator/filter/ExpressionFilterOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4925/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvRXhwcmVzc2lvbkZpbHRlck9wZXJhdG9yLmphdmE=) | `71.14% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/pinot/tools/scan/query/NotInPredicateFilter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4925/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3NjYW4vcXVlcnkvTm90SW5QcmVkaWNhdGVGaWx0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/pinot/tools/scan/query/InPredicateFilter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4925/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3NjYW4vcXVlcnkvSW5QcmVkaWNhdGVGaWx0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...he/pinot/core/common/predicate/NotInPredicate.java](https://codecov.io/gh/apache/incubator-pinot/pull/4925/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vcHJlZGljYXRlL05vdEluUHJlZGljYXRlLmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...he/pinot/core/common/predicate/RangePredicate.java](https://codecov.io/gh/apache/incubator-pinot/pull/4925/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vcHJlZGljYXRlL1JhbmdlUHJlZGljYXRlLmphdmE=) | `100% <100%> (+9.52%)` | `0 <0> (ø)` | :arrow_down: |
| [...lter/predicate/NotInPredicateEvaluatorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4925/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvcHJlZGljYXRlL05vdEluUHJlZGljYXRlRXZhbHVhdG9yRmFjdG9yeS5qYXZh) | `92.22% <100%> (+0.36%)` | `0 <0> (ø)` | :arrow_down: |
| ... and [50 more](https://codecov.io/gh/apache/incubator-pinot/pull/4925/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4925?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4925?src=pr&el=footer). Last update [acaa78d...55fe9a1](https://codecov.io/gh/apache/incubator-pinot/pull/4925?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org