You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2022/01/22 15:23:02 UTC
[GitHub] [parquet-mr] shangxinli opened a new pull request #943: PARQUET-2112: Fix typo in MessageColumnIO
shangxinli opened a new pull request #943:
URL: https://github.com/apache/parquet-mr/pull/943
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] shangxinli commented on pull request #943: PARQUET-2112: Fix typo in MessageColumnIO
Posted by GitBox <gi...@apache.org>.
shangxinli commented on pull request #943:
URL: https://github.com/apache/parquet-mr/pull/943#issuecomment-1019590760
@ggershinsky, can you have a review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] shangxinli merged pull request #943: PARQUET-2112: Fix typo in MessageColumnIO
Posted by GitBox <gi...@apache.org>.
shangxinli merged pull request #943:
URL: https://github.com/apache/parquet-mr/pull/943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] shangxinli commented on a change in pull request #943: PARQUET-2112: Fix typo in MessageColumnIO
Posted by GitBox <gi...@apache.org>.
shangxinli commented on a change in pull request #943:
URL: https://github.com/apache/parquet-mr/pull/943#discussion_r790988892
##########
File path: parquet-column/src/main/java/org/apache/parquet/io/MessageColumnIO.java
##########
@@ -186,32 +186,32 @@
private int currentLevel = 0;
private class FieldsMarker {
- private BitSet vistedIndexes = new BitSet();
+ private BitSet visitedIndexes = new BitSet();
@Override
public String toString() {
return "VistedIndex{" +
Review comment:
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] ggershinsky commented on a change in pull request #943: PARQUET-2112: Fix typo in MessageColumnIO
Posted by GitBox <gi...@apache.org>.
ggershinsky commented on a change in pull request #943:
URL: https://github.com/apache/parquet-mr/pull/943#discussion_r790512086
##########
File path: parquet-column/src/main/java/org/apache/parquet/io/MessageColumnIO.java
##########
@@ -186,32 +186,32 @@
private int currentLevel = 0;
private class FieldsMarker {
- private BitSet vistedIndexes = new BitSet();
+ private BitSet visitedIndexes = new BitSet();
@Override
public String toString() {
return "VistedIndex{" +
Review comment:
one more typo in this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] shangxinli merged pull request #943: PARQUET-2112: Fix typo in MessageColumnIO
Posted by GitBox <gi...@apache.org>.
shangxinli merged pull request #943:
URL: https://github.com/apache/parquet-mr/pull/943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] shangxinli commented on a change in pull request #943: PARQUET-2112: Fix typo in MessageColumnIO
Posted by GitBox <gi...@apache.org>.
shangxinli commented on a change in pull request #943:
URL: https://github.com/apache/parquet-mr/pull/943#discussion_r790988892
##########
File path: parquet-column/src/main/java/org/apache/parquet/io/MessageColumnIO.java
##########
@@ -186,32 +186,32 @@
private int currentLevel = 0;
private class FieldsMarker {
- private BitSet vistedIndexes = new BitSet();
+ private BitSet visitedIndexes = new BitSet();
@Override
public String toString() {
return "VistedIndex{" +
Review comment:
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org