[commons-numbers] 07/32: Fix spotbugs configuration in build section.

[ah...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit 27f71ae31852905feef8ad2a821a65fad911ce78
Author: Alex Herbert <ah...@apache.org>
AuthorDate: Wed Nov 6 22:49:45 2019 +0000

    Fix spotbugs configuration in build section.
    
    Added an exclusion for the BrentSolver.
---
 pom.xml                                                 | 5 +++++
 src/main/resources/spotbugs/spotbugs-exclude-filter.xml | 7 ++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 9958e8c..f44a230 100644
--- a/pom.xml
+++ b/pom.xml
@@ -265,6 +265,11 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <version>${commons.spotbugs.version}</version>
+        <configuration>
+          <threshold>Normal</threshold>
+          <effort>Default</effort>
+          <excludeFilterFile>${numbers.parent.dir}/src/main/resources/spotbugs/spotbugs-exclude-filter.xml</excludeFilterFile>
+        </configuration>
       </plugin>
       <plugin>
         <groupId>org.apache.rat</groupId>
diff --git a/src/main/resources/spotbugs/spotbugs-exclude-filter.xml b/src/main/resources/spotbugs/spotbugs-exclude-filter.xml
index 9993593..d533776 100644
--- a/src/main/resources/spotbugs/spotbugs-exclude-filter.xml
+++ b/src/main/resources/spotbugs/spotbugs-exclude-filter.xml
@@ -26,6 +26,11 @@
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xsi:schemaLocation="https://github.com/spotbugs/filter/3.1.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd">
 
-  <Class name="~.*\.jmh\.generated\..*" />
+  <Match>
+    <!-- The Brent method deliberately checks equality. -->
+    <Class name="org.apache.commons.numbers.rootfinder.BrentSolver"/>
+    <Method name="brent"/>
+    <BugPattern name="FE_FLOATING_POINT_EQUALITY"/>
+  </Match>
 
 </FindBugsFilter>