You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Pua (Jira)" <ji...@apache.org> on 2020/08/24 13:13:00 UTC
[jira] [Comment Edited] (FLINK-19038) It doesn't support to call
Table.limit() continuously
[ https://issues.apache.org/jira/browse/FLINK-19038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183252#comment-17183252 ]
Pua edited comment on FLINK-19038 at 8/24/20, 1:12 PM:
-------------------------------------------------------
I think the root cause is here
[https://github.com/apache/flink/blob/master/flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/utils/SortOperationFactory.java#L125]
Only the previousSort.getFetch() of first fetch should be -1,and the others' is its previous.
My be we should remove the judgement，if we want to support continuously fetch.
was (Author: zhushang):
I think the root cause is here
[https://github.com/apache/flink/blob/master/flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/utils/SortOperationFactory.java#L125]
Only the previousSort.getFetch() of first fetch should be -1,and the others' is its previous.
My be we should remove the judge，if we want to support continuously fetch.
> It doesn't support to call Table.limit() continuously
> -----------------------------------------------------
>
> Key: FLINK-19038
> URL: https://issues.apache.org/jira/browse/FLINK-19038
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / API
> Affects Versions: 1.12.0
> Reporter: Dian Fu
> Priority: Major
> Fix For: 1.12.0
>
>
> For example, table.limit(3).limit(2) will failed with "FETCH is already defined."
> {code}
> org.apache.flink.table.api.ValidationException: FETCH is already defined.
> at org.apache.flink.table.operations.utils.SortOperationFactory.validateAndGetChildSort(SortOperationFactory.java:125)
> at org.apache.flink.table.operations.utils.SortOperationFactory.createLimitWithFetch(SortOperationFactory.java:105)
> at org.apache.flink.table.operations.utils.OperationTreeBuilder.limitWithFetch(OperationTreeBuilder.java:418)
> {code}
> However, as we support to call table.limit() without specifying the order, I guess this should be a valid usage and should be allowed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)