You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by mbarrientos <gi...@git.apache.org> on 2015/05/05 21:35:18 UTC
[GitHub] incubator-brooklyn pull request: Add initial support for PaaS loca...
GitHub user mbarrientos opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/629
Add initial support for PaaS locations
An initial support for PaaS locations is provided by adding a new inference rule to [ReflectiveEntityDriverFactory](https://github.com/mbarrientos/incubator-brooklyn/blob/f32fa3cff2174dae18758533e51bddb482eef2c2/core/src/main/java/brooklyn/entity/drivers/ReflectiveEntityDriverFactory.java). The new location [PaasLocation](https://github.com/apache/incubator-brooklyn/blob/f32fa3cff2174dae18758533e51bddb482eef2c2/core/src/main/java/brooklyn/location/paas/PaasLocation.java) is not based on SSH access and is not supposed to be provisioned first (even though it might be the case for some PaaS provider).
Note that this is part of an ongoing work for integrating PaaS providers, like CloudFoundry, as a Brooklyn Location, which process can be tracked [here](https://github.com/SeaCloudsEU/brooklyn-location-cloudfoundry). That work will be extending the one presented in this PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbarrientos/incubator-brooklyn feature/paas-location
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/629.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #629
----
commit f32fa3cff2174dae18758533e51bddb482eef2c2
Author: Miguel Barrientos <mb...@lcc.uma.es>
Date: 2015-05-05T19:02:27Z
Add initial support for PaaS locations by using ReflectiveEntityDriverFactory.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Add initial support for PaaS loca...
Posted by robertgmoss <gi...@git.apache.org>.
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/629#discussion_r29752721
--- Diff: core/src/test/java/brooklyn/location/basic/PaasLocationTest.java ---
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package brooklyn.location.basic;
+
+import brooklyn.location.paas.PaasLocation;
+import brooklyn.management.ManagementContext;
+import brooklyn.test.location.TestPaasLocation;
+import org.testng.Assert;
+import org.testng.annotations.Test;
+
+public class PaasLocationTest {
+
+ private PaasLocation location;
+ private ManagementContext mgmt;
--- End diff --
This ManagementContext field is not used
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Add initial support for PaaS loca...
Posted by robertgmoss <gi...@git.apache.org>.
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/629#discussion_r29752708
--- Diff: core/src/test/java/brooklyn/entity/drivers/ReflectiveEntityDriverFactoryTest.java ---
@@ -54,12 +58,22 @@ protected void assertDriverIs(Class<?> clazz) {
assertTrue(driver.getClass().equals(clazz), "driver="+driver+"; should be "+clazz);
}
+ protected void assertDriverIs(Class<?> clazz, Location location) {
--- End diff --
why not eliminate duplicate code and use this method for the existing test, too?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Add initial support for PaaS loca...
Posted by mbarrientos <gi...@git.apache.org>.
Github user mbarrientos commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/629#discussion_r29763611
--- Diff: core/src/test/java/brooklyn/entity/drivers/ReflectiveEntityDriverFactoryTest.java ---
@@ -54,12 +58,22 @@ protected void assertDriverIs(Class<?> clazz) {
assertTrue(driver.getClass().equals(clazz), "driver="+driver+"; should be "+clazz);
}
+ protected void assertDriverIs(Class<?> clazz, Location location) {
--- End diff --
@robertgmoss I agree. I didn't wanted to include many changes on the rest of tests but that's cleaner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-brooklyn pull request: Add initial support for
PaaS loca...
Posted by Robert Moss <ro...@cloudsoftcorp.com>.
Yep, LGTM
On May 13, 2015 5:16 AM, "andreaturli" <gi...@git.apache.org> wrote:
> Github user andreaturli commented on the pull request:
>
>
> https://github.com/apache/incubator-brooklyn/pull/629#issuecomment-101644686
>
> @robertgmoss do you think it is good to merge now?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] incubator-brooklyn pull request: Add initial support for PaaS loca...
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/629#issuecomment-101644686
@robertgmoss do you think it is good to merge now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Add initial support for PaaS loca...
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/629#issuecomment-101718525
thanks @robertgmoss
Thanks @mbarrientos! Looking forward for the other PRs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Add initial support for PaaS loca...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/629
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---