You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/04/13 15:12:17 UTC

[GitHub] [incubator-tubemq] Technoboy- opened a new pull request #52: [TUBEMQ-66] TubeSingleSessionFactory shutdown bug

Technoboy- opened a new pull request #52: [TUBEMQ-66] TubeSingleSessionFactory shutdown bug
URL: https://github.com/apache/incubator-tubemq/pull/52
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tubemq] Technoboy- commented on issue #52: [TUBEMQ-66] TubeSingleSessionFactory shutdown bug

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on issue #52: [TUBEMQ-66] TubeSingleSessionFactory shutdown bug
URL: https://github.com/apache/incubator-tubemq/pull/52#issuecomment-613187206
 
 
   > After this modification, there will be problems in Flink-like usage scenarios:
   > 
   > after the reference count is changed to the boolean value, if the TubeSingleSessionFactory object is initialized multiple times in the same process, as long as there is a shutdown() call, then the other executing logics in the same process will throw wrong infos.
   
   So we have to delete the referenceCounter.incrementAndGet() in the constructor?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tubemq] Technoboy- commented on issue #52: [TUBEMQ-66] TubeSingleSessionFactory shutdown bug

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on issue #52: [TUBEMQ-66] TubeSingleSessionFactory shutdown bug
URL: https://github.com/apache/incubator-tubemq/pull/52#issuecomment-613188902
 
 
   > The TubeMultiSessionFactory class has implemented your approach. The TubeSingleSessionFactory class is mainly used in the scheme of requiring shared connections
   
   
   
   > The TubeMultiSessionFactory class has implemented your approach. The TubeSingleSessionFactory class is mainly used in the scheme of requiring shared connections
   
   yes, i see. But not clear why call another time for referenceCounter.incrementAndGet() 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tubemq] Technoboy- closed pull request #52: [TUBEMQ-66] TubeSingleSessionFactory shutdown bug

Posted by GitBox <gi...@apache.org>.
Technoboy- closed pull request #52: [TUBEMQ-66] TubeSingleSessionFactory shutdown bug
URL: https://github.com/apache/incubator-tubemq/pull/52
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tubemq] gosonzhang commented on issue #52: [TUBEMQ-66] TubeSingleSessionFactory shutdown bug

Posted by GitBox <gi...@apache.org>.
gosonzhang commented on issue #52: [TUBEMQ-66] TubeSingleSessionFactory shutdown bug
URL: https://github.com/apache/incubator-tubemq/pull/52#issuecomment-613187755
 
 
   The TubeMultiSessionFactory class has implemented your approach. The TubeSingleSessionFactory class is mainly used in the scheme of requiring shared connections

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services