You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/02 06:56:38 UTC
[GitHub] [spark] LuciferYang opened a new pull request #31703: [SPARK-34587][CORE][SQL][DSTREAM][SS][2.4] Replaces map and getOrElse(false/true) with exists/forall
LuciferYang opened a new pull request #31703:
URL: https://github.com/apache/spark/pull/31703
### What changes were proposed in this pull request?
Replaces `map and getOrElse(false/true)` with `exists/forall`, it's semantically consistent, but looks simpler.
**Before**
```
option.map(booleanFunc).getOrElse(false)
option.map(booleanFunc).getOrElse(true)
```
**After**
```
option.exists(booleanFunc)
option.forall(booleanFunc)
```
### Why are the changes needed?
Code Simpilefications.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the Jenkins or GitHub Action
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31703: [SPARK-34587][CORE][SQL][DSTREAM][SS][2.4] Replaces map and getOrElse(false/true) with exists/forall
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31703:
URL: https://github.com/apache/spark/pull/31703#issuecomment-788694801
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40214/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31703: [SPARK-34587][CORE][SQL][DSTREAM][SS][2.4] Replaces map and getOrElse(false/true) with exists/forall
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31703:
URL: https://github.com/apache/spark/pull/31703#issuecomment-788664562
**[Test build #135633 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135633/testReport)** for PR 31703 at commit [`bafc45b`](https://github.com/apache/spark/commit/bafc45b2dc4f5f9d71deab230cf10ac2edf3c3d4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31703: [SPARK-34587][CORE][SQL][DSTREAM][SS][2.4] Replaces map and getOrElse(false/true) with exists/forall
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31703:
URL: https://github.com/apache/spark/pull/31703#issuecomment-788664562
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31703: [SPARK-34587][CORE][SQL][DSTREAM][SS][2.4] Replaces map and getOrElse(false/true) with exists/forall
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31703:
URL: https://github.com/apache/spark/pull/31703#issuecomment-788734587
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40220/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31703: [SPARK-34587][CORE][SQL][DSTREAM][SS][2.4] Replaces map and getOrElse(false/true) with exists/forall
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31703:
URL: https://github.com/apache/spark/pull/31703#issuecomment-788697844
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135640/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31703: [SPARK-34587][CORE][SQL][DSTREAM][SS][2.4] Replaces map and getOrElse(false/true) with exists/forall
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31703:
URL: https://github.com/apache/spark/pull/31703#issuecomment-788691512
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40214/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31703: [SPARK-34587][CORE][SQL][DSTREAM][SS][2.4] Replaces map and getOrElse(false/true) with exists/forall
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31703:
URL: https://github.com/apache/spark/pull/31703#issuecomment-788734587
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40220/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31703: [SPARK-34587][CORE][SQL][DSTREAM][SS][2.4] Replaces map and getOrElse(false/true) with exists/forall
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31703:
URL: https://github.com/apache/spark/pull/31703#issuecomment-788696891
**[Test build #135640 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135640/testReport)** for PR 31703 at commit [`f93caa9`](https://github.com/apache/spark/commit/f93caa9bebab30ebed55ac1fada6a24e0a86cb20).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31703: [SPARK-34587][CORE][SQL][DSTREAM][SS][2.4] Replaces map and getOrElse(false/true) with exists/forall
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31703:
URL: https://github.com/apache/spark/pull/31703#issuecomment-788665670
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135633/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31703: [SPARK-34587][CORE][SQL][DSTREAM][SS][2.4] Replaces map and getOrElse(false/true) with exists/forall
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31703:
URL: https://github.com/apache/spark/pull/31703#issuecomment-788665670
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135633/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang closed pull request #31703: [SPARK-34587][CORE][SQL][DSTREAM][SS][2.4] Replaces map and getOrElse(false/true) with exists/forall
Posted by GitBox <gi...@apache.org>.
LuciferYang closed pull request #31703:
URL: https://github.com/apache/spark/pull/31703
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31703: [SPARK-34587][CORE][SQL][DSTREAM][SS][2.4] Replaces map and getOrElse(false/true) with exists/forall
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31703:
URL: https://github.com/apache/spark/pull/31703#issuecomment-788729370
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40220/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31703: [SPARK-34587][CORE][SQL][DSTREAM][SS][2.4] Replaces map and getOrElse(false/true) with exists/forall
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31703:
URL: https://github.com/apache/spark/pull/31703#issuecomment-788714877
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40220/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31703: [SPARK-34587][CORE][SQL][DSTREAM][SS][2.4] Replaces map and getOrElse(false/true) with exists/forall
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31703:
URL: https://github.com/apache/spark/pull/31703#issuecomment-788697844
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135640/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31703: [SPARK-34587][CORE][SQL][DSTREAM][SS][2.4] Replaces map and getOrElse(false/true) with exists/forall
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31703:
URL: https://github.com/apache/spark/pull/31703#issuecomment-788680895
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40214/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31703: [SPARK-34587][CORE][SQL][DSTREAM][SS][2.4] Replaces map and getOrElse(false/true) with exists/forall
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31703:
URL: https://github.com/apache/spark/pull/31703#issuecomment-788696891
**[Test build #135640 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135640/testReport)** for PR 31703 at commit [`f93caa9`](https://github.com/apache/spark/commit/f93caa9bebab30ebed55ac1fada6a24e0a86cb20).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31703: [SPARK-34587][CORE][SQL][DSTREAM][SS][2.4] Replaces map and getOrElse(false/true) with exists/forall
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31703:
URL: https://github.com/apache/spark/pull/31703#issuecomment-788694801
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40214/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31703: [SPARK-34587][CORE][SQL][DSTREAM][SS][2.4] Replaces map and getOrElse(false/true) with exists/forall
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31703:
URL: https://github.com/apache/spark/pull/31703#issuecomment-788697830
**[Test build #135640 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135640/testReport)** for PR 31703 at commit [`f93caa9`](https://github.com/apache/spark/commit/f93caa9bebab30ebed55ac1fada6a24e0a86cb20).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org