You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/02/26 00:55:02 UTC
Review Request 44049: avoid blocking a thread that is sending an
Alert via UDP
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44049/
-----------------------------------------------------------
Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
Repository: geode
Description
-------
This is a fix from a maintenance branch of GemFire. If disable-tcp=true it is possible for the system to freeze up during a network partition if there are Alert listeners in the distributed system. The JGroups FlowControl protocols may block the alert waiting for replenishment from the listener. The fix is to bypass the FlowControl protocols when sending Alert messages. Retransmission protocols in lower-levels of the JGroups stack will ensure proper delivery of the messages without blocking the thread that is sending them.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java f3ba7a2013083030498aca1a96367730a1c44e32
Diff: https://reviews.apache.org/r/44049/diff/
Testing
-------
Thanks,
Bruce Schuchardt
Re: Review Request 44049: avoid blocking a thread that is sending an
Alert via UDP
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44049/#review120805
-----------------------------------------------------------
Ship it!
Ship It!
- Hitesh Khamesra
On Feb. 25, 2016, 11:55 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44049/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 11:55 p.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This is a fix from a maintenance branch of GemFire. If disable-tcp=true it is possible for the system to freeze up during a network partition if there are Alert listeners in the distributed system. The JGroups FlowControl protocols may block the alert waiting for replenishment from the listener. The fix is to bypass the FlowControl protocols when sending Alert messages. Retransmission protocols in lower-levels of the JGroups stack will ensure proper delivery of the messages without blocking the thread that is sending them.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java f3ba7a2013083030498aca1a96367730a1c44e32
>
> Diff: https://reviews.apache.org/r/44049/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bruce Schuchardt
>
>