You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/05/21 20:13:31 UTC

Review Request 21781: Removing --groups_per_batch option.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21781/
-----------------------------------------------------------

Review request for Aurora, Joe Smith and Brian Wickman.


Bugs: AURORA-446
    https://issues.apache.org/jira/browse/AURORA-446


Repository: aurora


Description
-------

Removing --groups_per_batch option.


Diffs
-----

  src/main/python/apache/aurora/admin/host_maintenance.py 16c18bc563c61e37055a8ad81082d60d1662afb2 
  src/main/python/apache/aurora/client/commands/maintenance.py 68d63a12bb92bb2f50ae45363513892ad9bbb1ff 
  src/test/python/apache/aurora/admin/test_host_maintenance.py 18bf6223adb6b64cc76c2810abc317ef063e16e2 

Diff: https://reviews.apache.org/r/21781/diff/


Testing
-------

./pants src/test/python:all


Thanks,

Maxim Khutornenko


Re: Review Request 21781: Removing --groups_per_batch option.

Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21781/#review43798
-----------------------------------------------------------

Ship it!


Ship It!

- Brian Wickman


On May 21, 2014, 6:13 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21781/
> -----------------------------------------------------------
> 
> (Updated May 21, 2014, 6:13 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Brian Wickman.
> 
> 
> Bugs: AURORA-446
>     https://issues.apache.org/jira/browse/AURORA-446
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Removing --groups_per_batch option.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 16c18bc563c61e37055a8ad81082d60d1662afb2 
>   src/main/python/apache/aurora/client/commands/maintenance.py 68d63a12bb92bb2f50ae45363513892ad9bbb1ff 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 18bf6223adb6b64cc76c2810abc317ef063e16e2 
> 
> Diff: https://reviews.apache.org/r/21781/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Re: Review Request 21781: Removing --groups_per_batch option.

Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21781/#review43797
-----------------------------------------------------------

Ship it!


Ship It!

- Joe Smith


On May 21, 2014, 11:13 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21781/
> -----------------------------------------------------------
> 
> (Updated May 21, 2014, 11:13 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Brian Wickman.
> 
> 
> Bugs: AURORA-446
>     https://issues.apache.org/jira/browse/AURORA-446
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Removing --groups_per_batch option.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 16c18bc563c61e37055a8ad81082d60d1662afb2 
>   src/main/python/apache/aurora/client/commands/maintenance.py 68d63a12bb92bb2f50ae45363513892ad9bbb1ff 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 18bf6223adb6b64cc76c2810abc317ef063e16e2 
> 
> Diff: https://reviews.apache.org/r/21781/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>