You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by do...@apache.org on 2023/01/13 18:50:08 UTC
[arrow] branch master updated: GH-15156: [JS] Fix can't find variable: BigInt64Array (#15157)
This is an automated email from the ASF dual-hosted git repository.
domoritz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new a64e63668c GH-15156: [JS] Fix can't find variable: BigInt64Array (#15157)
a64e63668c is described below
commit a64e63668ce5354a5f43bc171b4e56e1c83311f7
Author: Julien Roncaglia <fo...@vbfox.net>
AuthorDate: Fri Jan 13 19:49:57 2023 +0100
GH-15156: [JS] Fix can't find variable: BigInt64Array (#15157)
Use the `BigInt64Array` and `BigUint64Array` types from `compat.ts` where it wasn't used.
This fixes the `ReferenceError: Can't find variable: BigInt64Array` that appears when the library is used in a browser without that support.
* Closes: #15156
Authored-by: Julien Roncaglia <ju...@waldo.com>
Signed-off-by: Dominik Moritz <do...@gmail.com>
---
js/src/type.ts | 1 +
js/src/util/pretty.ts | 2 ++
js/src/vector.ts | 1 +
3 files changed, 4 insertions(+)
diff --git a/js/src/type.ts b/js/src/type.ts
index 4d0fbbfc60..7674705dad 100644
--- a/js/src/type.ts
+++ b/js/src/type.ts
@@ -21,6 +21,7 @@ import { MapRow } from './row/map.js';
import { StructRow, StructRowProxy } from './row/struct.js';
import { Long } from 'flatbuffers';
import { TypedArrayConstructor } from './interfaces.js';
+import { BigInt64Array, BigUint64Array } from './util/compat.js';
import {
Type,
diff --git a/js/src/util/pretty.ts b/js/src/util/pretty.ts
index de8fec3f5c..de1b77c09a 100644
--- a/js/src/util/pretty.ts
+++ b/js/src/util/pretty.ts
@@ -15,6 +15,8 @@
// specific language governing permissions and limitations
// under the License.
+import { BigInt64Array, BigUint64Array } from './compat.js';
+
/** @ignore */ const undf = void (0);
/** @ignore */
diff --git a/js/src/vector.ts b/js/src/vector.ts
index 28c6aad5a8..a2baf83c95 100644
--- a/js/src/vector.ts
+++ b/js/src/vector.ts
@@ -30,6 +30,7 @@ import {
wrapChunkedCall2,
wrapChunkedIndexOf,
} from './util/chunk.js';
+import { BigInt64Array, BigUint64Array } from './util/compat.js';
import { instance as getVisitor } from './visitor/get.js';
import { instance as setVisitor } from './visitor/set.js';