You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2023/03/13 16:25:12 UTC

[GitHub] [spark] viirya commented on a diff in pull request #40392: [SPARK-42769][K8S] Add `SPARK_DRIVER_POD_IP` env variable to executor pods

viirya commented on code in PR #40392:
URL: https://github.com/apache/spark/pull/40392#discussion_r1134259551


##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala:
##########
@@ -54,6 +54,7 @@ private[spark] object Constants {
   val UI_PORT_NAME = "spark-ui"
 
   // Environment Variables
+  val ENV_DRIVER_POD_IP = "SPARK_DRIVER_POD_IP"

Review Comment:
   Is it different to `DRIVER_HOST_ADDRESS`? I saw K8s uses `DRIVER_HOST_ADDRESS` to derive driver url for env var `ENV_DRIVER_URL`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org