You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/14 05:53:15 UTC
[GitHub] [incubator-superset] labelhero opened a new issue #8962: jinja
url_param in Sql_lab sql query not working
labelhero opened a new issue #8962: jinja url_param in Sql_lab sql query not working
URL: https://github.com/apache/incubator-superset/issues/8962
Unable to run query after passing url_param parameters to sql_lab query. Button does not do anything.
This functionality used to run in 0.28 version, however after upgrading to 0.35 it not running anymore.
Are these fields supposed to be pre-filled using url_param?
Can some one please help with this, if possible please post some examples on how to pass url_param in newer version.
A clear and concise description of what the bug is.
### Expected results
what you expected to happen.
### Actual results
what actually happens.
#### Screenshots
If applicable, add screenshots to help explain your problem.
#### How to reproduce the bug
1. Pass the table parameters in the url and sql query with url_param
2. All database,schema and table fields are supposed to be empty.
3. Click "Run query" button.
4. Nothing happens.
### Environment
(please complete the following information):
- superset version: `0.35.1`
- python version: `3.6`
- node.js version: `node -v`
- npm version: `npm -v`
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] pbgc edited a comment on issue #8962: jinja
url_param in Sql_lab sql query not working
Posted by GitBox <gi...@apache.org>.
pbgc edited a comment on issue #8962: jinja url_param in Sql_lab sql query not working
URL: https://github.com/apache/incubator-superset/issues/8962#issuecomment-581459577
> There was a fix related to `url_params` that was included in `0.35.1`, see #8536 . However, that particular PR focused on all other areas of Superset **except** SqlLab. I can look into this in the coming days.
@villebro I try to do exactly (I think...) of what it's shown in the PR and it does not work. url_params in the dashboard are not being passed to the chart and then to the datasource sql.
I'm on 0.35.2
EDIT: @villebro please ignore .. I after saw the PR was applied after 0.35.2 .. thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro edited a comment on issue #8962:
jinja url_param in Sql_lab sql query not working
Posted by GitBox <gi...@apache.org>.
villebro edited a comment on issue #8962: jinja url_param in Sql_lab sql query not working
URL: https://github.com/apache/incubator-superset/issues/8962#issuecomment-574514446
This does appear to be a regression, not sure when it was introduced. I need to think about how to resolve this, as there are many potential solutions. Also, the `url_params` feature needs to be more thoroughly unit tested and documented going forward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] pbgc commented on issue #8962: jinja url_param
in Sql_lab sql query not working
Posted by GitBox <gi...@apache.org>.
pbgc commented on issue #8962: jinja url_param in Sql_lab sql query not working
URL: https://github.com/apache/incubator-superset/issues/8962#issuecomment-581459577
> There was a fix related to `url_params` that was included in `0.35.1`, see #8536 . However, that particular PR focused on all other areas of Superset **except** SqlLab. I can look into this in the coming days.
@villebro I try to do exactly (I think...) of what it's shown in the PR and it does not work. url_params in the dashboard are not being passed to the chart and then to the datasource sql.
I'm on 0.35.2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8962: jinja
url_param in Sql_lab sql query not working
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #8962: jinja url_param in Sql_lab sql query not working
URL: https://github.com/apache/incubator-superset/issues/8962#issuecomment-574029613
There was a fix related to `url_params` that was included in `0.35.1`, see #8536 . However, that particular PR focused on all other areas of Superset **except** SqlLab. I can look into this in the coming days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] closed issue #8962: jinja url_param
in Sql_lab sql query not working
Posted by GitBox <gi...@apache.org>.
stale[bot] closed issue #8962: jinja url_param in Sql_lab sql query not working
URL: https://github.com/apache/incubator-superset/issues/8962
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8962: jinja
url_param in Sql_lab sql query not working
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #8962: jinja url_param in Sql_lab sql query not working
URL: https://github.com/apache/incubator-superset/issues/8962#issuecomment-574514446
This does appear to be a regression, not sure when it was introduced. I need to think about how to resolve this, as there are many potential solutions. Also, the (`url_params`) feature needs to be more thoroughly unit tested and documented going forward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8962:
jinja url_param in Sql_lab sql query not working
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #8962: jinja url_param in Sql_lab sql query not working
URL: https://github.com/apache/incubator-superset/issues/8962#issuecomment-574014534
Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.84. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #8962: jinja
url_param in Sql_lab sql query not working
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #8962: jinja url_param in Sql_lab sql query not working
URL: https://github.com/apache/incubator-superset/issues/8962#issuecomment-608668675
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org