[GitHub] [kafka] ijuma commented on a diff in pull request #13241: KAFKA-14711: kafaka-metadata-quorum.sh does not honor --command-confi…

["ijuma (via GitHub)" <gi...@apache.org>]

ijuma commented on code in PR #13241:
URL: https://github.com/apache/kafka/pull/13241#discussion_r1105053282


##########
tools/src/main/java/org/apache/kafka/tools/MetadataQuorumCommand.java:
##########
@@ -116,6 +111,16 @@ static void execute(String... args) throws Exception {
         }
     }
 
+    private static Properties getProperties(File optionalCommandConfig) throws TerseException, IOException {
+        if (optionalCommandConfig == null) {
+            return new Properties();
+        } else {
+            if (!optionalCommandConfig.exists())
+                throw new TerseException("Properties file " + optionalCommandConfig.getPath() + " does not exists!");

Review Comment:
   That's not required by the coding guidelines though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org