You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "NicolaIsotta (via GitHub)" <gi...@apache.org> on 2026/09/17 11:57:56 UTC

[PR] JSF: support custom component new URN namespace [netbeans]

NicolaIsotta opened a new pull request, #9625:
URL: https://github.com/apache/netbeans/pull/9625

   Update the JSF custom component wizard and metamodel to use "jakarta.faces.component" as the default tag namespace on Jakarta Faces projects while preserving "http://xmlns.jcp.org/jsf/component" for legacy JSF versions.
   
   
   ---
   **^Add meaningful description above**
   
   <details open>
   <summary>Click to collapse/expand PR instructions</summary>
   
   By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
   
    - are all your own work, and you have the right to contribute them.
    - are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
   
   ### LLMs, Commit messages and PR description:
   
    - Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
    - LLM assisted commits should be attributed with an `Assisted-by: MODEL_NAME MODEL_VERSION` line appended to the commit message.
      - Please mention coding assistance in the PR description too (eg. by adding the same `Assisted-by` line from above)
      - Please describe the changes in your own words - we'd like to know you understand the changes being made!
   
   If you're a first time contributor, see the Contributing guidelines for more information.
   
   If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
   
   ### PR approval and merge checklist:
   
   1. [ ] Was this PR [correctly labeled](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240884239#PRsandYouAreviewerGuide-PRtriggeredCIJobs(conditionalCIpipeline)), did the right tests run? When did they run?
   2. [ ] Is this PR [squashed](https://cwiki.apache.org/confluence/display/NETBEANS/git%3A+squash+and+merge)?
   3. [ ] Are author name / email address correct? Are [co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line) correctly listed? Do the commit messages need updates?
   3. [ ] Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?
   
   If this PR targets the delivery branch: [don't merge](https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery). ([full wiki article](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide))
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] JSF: support custom component new URN namespace [netbeans]

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #9625:
URL: https://github.com/apache/netbeans/pull/9625#discussion_r4086086755


##########
enterprise/web.jsf/src/org/netbeans/modules/web/jsf/impl/metamodel/ComponentImpl.java:
##########
@@ -120,4 +123,18 @@ public boolean refresh(TypeElement typeElement) {
         }
         return true;
     }
+
+    /**
+     * @return The {@code NAMESPACE} constant of the {@code @FacesComponent} annotation
+     */
+    private static String getDefaultNamespace(AnnotationMirror annotationMirror) {
+        Element annotationType = annotationMirror.getAnnotationType().asElement();
+        for (VariableElement field : ElementFilter.fieldsIn(annotationType.getEnclosedElements())) {
+            if ("NAMESPACE".contentEquals(field.getSimpleName()) // NOI18N
+                    && field.getConstantValue() instanceof String namespace) {
+                return namespace;
+            }
+        }
+        return null; // no namespace field on jsf 2.1-

Review Comment:
   Makes sense. Thank you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] JSF: support custom component new URN namespace [netbeans]

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing merged PR #9625:
URL: https://github.com/apache/netbeans/pull/9625


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] JSF: support custom component new URN namespace [netbeans]

Posted by "NicolaIsotta (via GitHub)" <gi...@apache.org>.
NicolaIsotta commented on PR #9625:
URL: https://github.com/apache/netbeans/pull/9625#issuecomment-5757723483

   Fixed now - we can get the default name space directly from the annotation, pretty elegant IMHO


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] JSF: support custom component new URN namespace [netbeans]

Posted by "NicolaIsotta (via GitHub)" <gi...@apache.org>.
NicolaIsotta commented on code in PR #9625:
URL: https://github.com/apache/netbeans/pull/9625#discussion_r4075862958


##########
enterprise/web.jsf/src/org/netbeans/modules/web/jsf/impl/metamodel/ComponentImpl.java:
##########
@@ -120,4 +123,18 @@ public boolean refresh(TypeElement typeElement) {
         }
         return true;
     }
+
+    /**
+     * @return The {@code NAMESPACE} constant of the {@code @FacesComponent} annotation
+     */
+    private static String getDefaultNamespace(AnnotationMirror annotationMirror) {
+        Element annotationType = annotationMirror.getAnnotationType().asElement();
+        for (VariableElement field : ElementFilter.fieldsIn(annotationType.getEnclosedElements())) {
+            if ("NAMESPACE".contentEquals(field.getSimpleName()) // NOI18N
+                    && field.getConstantValue() instanceof String namespace) {
+                return namespace;
+            }
+        }
+        return null; // no namespace field on jsf 2.1-

Review Comment:
   IMHO it makes more sense to return null since JSF 2.1- did not have the `namespace` field.
   It won't be checked anyway since `createTag` was missing too.
   https://javadoc.io/static/javax.faces/javax.faces-api/2.1/javax/faces/component/FacesComponent.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] JSF: support custom component new URN namespace [netbeans]

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #9625:
URL: https://github.com/apache/netbeans/pull/9625#discussion_r4073102091


##########
enterprise/web.jsf/src/org/netbeans/modules/web/jsf/impl/metamodel/ComponentImpl.java:
##########
@@ -120,4 +123,18 @@ public boolean refresh(TypeElement typeElement) {
         }
         return true;
     }
+
+    /**
+     * @return The {@code NAMESPACE} constant of the {@code @FacesComponent} annotation
+     */
+    private static String getDefaultNamespace(AnnotationMirror annotationMirror) {
+        Element annotationType = annotationMirror.getAnnotationType().asElement();
+        for (VariableElement field : ElementFilter.fieldsIn(annotationType.getEnclosedElements())) {
+            if ("NAMESPACE".contentEquals(field.getSimpleName()) // NOI18N
+                    && field.getConstantValue() instanceof String namespace) {
+                return namespace;
+            }
+        }
+        return null; // no namespace field on jsf 2.1-

Review Comment:
   Why not retain the static field `DEFAULT_COMPONENT_NS` and return its value here as fallback?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] JSF: support custom component new URN namespace [netbeans]

Posted by "NicolaIsotta (via GitHub)" <gi...@apache.org>.
NicolaIsotta commented on PR #9625:
URL: https://github.com/apache/netbeans/pull/9625#issuecomment-5742351491

   I'm marking thias as draft since the fix it's gonna be not as simple as I thought - Faces 3 has the jakarta package, but still relies on the old namespace: the new namespaces were introduced with Faces 4.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists