You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/08/29 13:45:55 UTC
[GitHub] [cloudstack] rp- opened a new pull request, #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
rp- opened a new pull request, #6682:
URL: https://github.com/apache/cloudstack/pull/6682
### Description
This PR has 3 improvements for the Linstor primary storage driver:
- Create a separate jar of it and move all Linstor related classes into the correct project (similar to the storpool plugin)
- Add aux properties for Cloudstack volumes in Linstor to make it easier to identify them in Linstor
- Add support for IOPs settings with the Linstor storage plugin
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Local test cluster with the Linstor primary storage driver in place.
Creating VMs and volumes and moving them between different disk-offerings.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1247727402
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6682)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6682&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6682&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6682&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=CODE_SMELL) [14 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_duplicated_lines_density&view=list) [2.8% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1253301338
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1262104935
I think it's some intermittent pkging error @rp- I'll rekick them again.
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1259439145
@rp- can you look at the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#discussion_r983564651
##########
debian/rules:
##########
@@ -42,6 +42,7 @@ override_dh_auto_install:
install -D plugins/hypervisors/kvm/target/cloud-plugin-hypervisor-kvm-$(VERSION).jar $(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/
install -D plugins/hypervisors/kvm/target/dependencies/* $(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/
install -D plugins/storage/volume/storpool/target/cloud-plugin-storage-volume-storpool-$(VERSION).jar $(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/
+ install -D plugins/storage/volume/storpool/target/cloud-plugin-storage-volume-linstor-$(VERSION).jar $(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/
Review Comment:
@rp- , during the packaging phase the following is reported:
```
install -D plugins/storage/volume/storpool/target/cloud-plugin-storage-volume-linstor-4.18.0.0-shapeblue5122.jar "debian/tmp"/usr/share/cloudstack-agent/lib/
install: cannot stat 'plugins/storage/volume/storpool/target/cloud-plugin-storage-volume-linstor-4.18.0.0-shapeblue5122.jar': No such file or directory
debian/rules:26: recipe for target 'override_dh_auto_install' failed
make[1]: *** [override_dh_auto_install] Error 1
make[1]: Leaving directory '/jenkins/workspace/acs-deb-pkg-builder'
debian/rules:9: recipe for target 'binary' failed
make: *** [binary] Error 2
dpkg-buildpackage: error: debian/rules binary gave error exit status 2
Build step 'Execute shell' marked build as failure
```
I think you made a typo here:
```suggestion
install -D plugins/storage/volume/linstor/target/cloud-plugin-storage-volume-linstor-$(VERSION).jar $(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/
```
???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1262328024
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1230405546
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6682)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6682&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6682&resolved=false&types=SECURITY_HOTSPOT) [1 Security Hotspot](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6682&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=CODE_SMELL) [14 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_duplicated_lines_density&view=list) [2.8% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1230402732
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6682?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6682](https://codecov.io/gh/apache/cloudstack/pull/6682?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ca00c7e) into [main](https://codecov.io/gh/apache/cloudstack/commit/c5262443595e4ed1bb9898654f3bed728331ffc0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c526244) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #6682 +/- ##
============================================
- Coverage 5.87% 5.87% -0.01%
Complexity 3934 3934
============================================
Files 2454 2454
Lines 242683 242738 +55
Branches 37978 37990 +12
============================================
Hits 14261 14261
- Misses 226843 226898 +55
Partials 1579 1579
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6682?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../hypervisor/kvm/storage/LinstorStorageAdaptor.java](https://codecov.io/gh/apache/cloudstack/pull/6682/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9zdG9yYWdlL3ZvbHVtZS9saW5zdG9yL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2h5cGVydmlzb3Iva3ZtL3N0b3JhZ2UvTGluc3RvclN0b3JhZ2VBZGFwdG9yLmphdmE=) | `0.00% <ø> (ø)` | |
| [...oud/hypervisor/kvm/storage/LinstorStoragePool.java](https://codecov.io/gh/apache/cloudstack/pull/6682/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9zdG9yYWdlL3ZvbHVtZS9saW5zdG9yL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2h5cGVydmlzb3Iva3ZtL3N0b3JhZ2UvTGluc3RvclN0b3JhZ2VQb29sLmphdmE=) | `0.00% <ø> (ø)` | |
| [...tore/driver/LinstorPrimaryDataStoreDriverImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6682/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9zdG9yYWdlL3ZvbHVtZS9saW5zdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N0b3JhZ2UvZGF0YXN0b3JlL2RyaXZlci9MaW5zdG9yUHJpbWFyeURhdGFTdG9yZURyaXZlckltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ifecycle/LinstorPrimaryDataStoreLifeCycleImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6682/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9zdG9yYWdlL3ZvbHVtZS9saW5zdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N0b3JhZ2UvZGF0YXN0b3JlL2xpZmVjeWNsZS9MaW5zdG9yUHJpbWFyeURhdGFTdG9yZUxpZmVDeWNsZUltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1261920193
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1263353678
<b>Trillian test result (tid-5056)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37576 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6682-t5056-kvm-centos7.zip
Smoke tests completed. 103 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rp- commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
rp- commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1261842574
@DaanHoogland done, even though the NPE was a false positive (but also my IDEA complained about it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1247666210
@rp- can you check the security hotspot?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1261920506
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1261834832
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6682)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6682&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6682&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6682&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=CODE_SMELL) [13 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_duplicated_lines_density&view=list) [2.8% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1261852161
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1262914310
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rp- commented on a diff in pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
rp- commented on code in PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#discussion_r983584152
##########
debian/rules:
##########
@@ -42,6 +42,7 @@ override_dh_auto_install:
install -D plugins/hypervisors/kvm/target/cloud-plugin-hypervisor-kvm-$(VERSION).jar $(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/
install -D plugins/hypervisors/kvm/target/dependencies/* $(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/
install -D plugins/storage/volume/storpool/target/cloud-plugin-storage-volume-storpool-$(VERSION).jar $(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/
+ install -D plugins/storage/volume/storpool/target/cloud-plugin-storage-volume-linstor-$(VERSION).jar $(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/
Review Comment:
yep correct, thanks for catching
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1262327643
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1262385227
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1262966970
<b>Trillian test result (tid-5045)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 57407 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6682-t5045-kvm-centos7.zip
Smoke tests completed. 92 look OK, 11 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestNetworkACL>:setup | `Error` | 0.00 | test_network_acl.py
ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py
test_DeleteDomain | `Error` | 6.02 | test_accounts.py
test_forceDeleteDomain | `Failure` | 6.06 | test_accounts.py
ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 7.02 | test_accounts.py
ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 8.37 | test_accounts.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
test_01_volume_usage | `Failure` | 787.82 | test_usage.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestAnnotations>:setup | `Error` | 0.00 | test_annotations.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
test_query_async_job_result | `Error` | 0.00 | test_async_job.py
test_nic_secondaryip_add_remove | `Failure` | 0.05 | test_multipleips_per_nic.py
test_01_create_template | `Error` | 10.34 | test_templates.py
test_CreateTemplateWithDuplicateName | `Error` | 18.67 | test_templates.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.47 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.43 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.41 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.41 | test_templates.py
test_03_delete_template | `Error` | 405.68 | test_templates.py
test_04_extract_template | `Error` | 1.07 | test_templates.py
test_09_list_templates_download_details | `Failure` | 0.04 | test_templates.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 593.40 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1247672832
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1253277658
Thanks @rp-
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1260392112
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1261796497
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1260869526
> SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6682)
>
> [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6682&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6682&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6682&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=CODE_SMELL) [13 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=CODE_SMELL)
>
> [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_duplicated_lines_density&view=list) [2.8% Duplica
tion](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_duplicated_lines_density&view=list)
@rp- looks mostly good but can you assess these ^^ I think some of them are easy to resolve. Of the bugs ignore the first one but please fix the second (potential NPE)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1230332575
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1262335242
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6682 (SL-JID-2438)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1253277880
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1261799528
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1259074303
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1260391526
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1261806062
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6682 (SL-JID-2433)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rp- commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
rp- commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1262103689
> Packaging result: heavy_check_mark el7 heavy_check_mark el8 heavy_multiplication_x debian heavy_check_mark suse15. SL-JID 4311
@rohityadavcloud is that debian packaging error my fault? where could I look up the error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1262418216
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6682)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6682&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6682&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6682&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=CODE_SMELL) [13 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_duplicated_lines_density&view=list) [2.8% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1230334005
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1261798900
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1262149561
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1262451170
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1262914512
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1260425617
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6682)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6682&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6682&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6682&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=CODE_SMELL) [13 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6682&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_duplicated_lines_density&view=list) [2.8% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6682&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1262105950
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rp- commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
rp- commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1253276735
@rohityadavcloud btw. I fixed the secuirty hotspot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1247672237
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1230340991
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6682 (SL-JID-2242)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1247683162
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6682 (SL-JID-2363)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1261796733
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1262386673
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1260396063
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6682 (SL-JID-2429)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rp- commented on pull request #6682: plugin-storage-volume-linstor: support QoS(IOPs) and small improvements
Posted by GitBox <gi...@apache.org>.
rp- commented on PR #6682:
URL: https://github.com/apache/cloudstack/pull/6682#issuecomment-1260391119
@DaanHoogland done and weird, because I just had todo a local rebase. no conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org