You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2016/06/07 23:25:35 UTC
Review Request 48383: fix IllegalStateException from importNewObject
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48383/
-----------------------------------------------------------
Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
Bugs: GEODE-1508
https://issues.apache.org/jira/browse/GEODE-1508
Repository: geode
Description
-------
The code in EntryEventImpl that calls importNewObject
is now careful to never call importNewObject with isSerialized false
if prefersNewSerialized is true.
The same bug was fixed for importOldObject.
Unit tests have been added for the code in EntryEventImpl
that calls both importNewObject and importOldObject.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java c4849be2c0863e6badf6eeaf1ccfaaf826d57584
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java 800527f2927cc775cf89426f12fc6eb6c48f77bb
Diff: https://reviews.apache.org/r/48383/diff/
Testing
-------
precheckin
Thanks,
Darrel Schneider
Re: Review Request 48383: fix IllegalStateException from
importNewObject
Posted by Ken Howe <kh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48383/#review137330
-----------------------------------------------------------
Ship it!
The description of the fix is somewhat misleading with regards to the conditions for calling importNewObject. For instance the conditional for isUnretainedNewReferenceOk() isn't mentioned.
That said, the code fix looks OK after I referred back to the orignal bug report and examined the implementation of the methods called.
- Ken Howe
On June 7, 2016, 11:25 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48383/
> -----------------------------------------------------------
>
> (Updated June 7, 2016, 11:25 p.m.)
>
>
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
>
>
> Bugs: GEODE-1508
> https://issues.apache.org/jira/browse/GEODE-1508
>
>
> Repository: geode
>
>
> Description
> -------
>
> The code in EntryEventImpl that calls importNewObject
> is now careful to never call importNewObject with isSerialized false
> if prefersNewSerialized is true.
> The same bug was fixed for importOldObject.
> Unit tests have been added for the code in EntryEventImpl
> that calls both importNewObject and importOldObject.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java c4849be2c0863e6badf6eeaf1ccfaaf826d57584
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java 800527f2927cc775cf89426f12fc6eb6c48f77bb
>
> Diff: https://reviews.apache.org/r/48383/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 48383: fix IllegalStateException from
importNewObject
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48383/
-----------------------------------------------------------
(Updated June 13, 2016, 4:14 p.m.)
Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
Bugs: GEODE-1508
https://issues.apache.org/jira/browse/GEODE-1508
Repository: geode
Description (updated)
-------
The code in EntryEventImpl that calls importNewObject
is now careful to never call importNewObject with isSerialized false
if isUnretainedNewReferenceOk is false.
The same bug was fixed for importOldObject.
Unit tests have been added for the code in EntryEventImpl
that calls both importNewObject and importOldObject.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java c4849be2c0863e6badf6eeaf1ccfaaf826d57584
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java 800527f2927cc775cf89426f12fc6eb6c48f77bb
Diff: https://reviews.apache.org/r/48383/diff/
Testing
-------
precheckin
Thanks,
Darrel Schneider
Re: Review Request 48383: fix IllegalStateException from
importNewObject
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48383/
-----------------------------------------------------------
(Updated June 13, 2016, 4:14 p.m.)
Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
Bugs: GEODE-1508
https://issues.apache.org/jira/browse/GEODE-1508
Repository: geode
Description (updated)
-------
The code in EntryEventImpl that calls importNewObject
is now careful to never call importNewObject with isSerialized false
if isUnretainedNewReferenceOk is true.
The same bug was fixed for importOldObject.
Unit tests have been added for the code in EntryEventImpl
that calls both importNewObject and importOldObject.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java c4849be2c0863e6badf6eeaf1ccfaaf826d57584
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java 800527f2927cc775cf89426f12fc6eb6c48f77bb
Diff: https://reviews.apache.org/r/48383/diff/
Testing
-------
precheckin
Thanks,
Darrel Schneider