[GitHub] [apisix] spacewander commented on a change in pull request #2905: fix: Basic auth plugin should run in rewrite phase.

[GitBox <gi...@apache.org>]

spacewander commented on a change in pull request #2905:
URL: https://github.com/apache/apisix/pull/2905#discussion_r533003982



##########
File path: apisix/init.lua
##########
@@ -513,6 +513,8 @@ function _M.http_access_phase()
                 api_ctx.consumer,
                 api_ctx
             )
+            core.log.debug("find consumer ", api_ctx.consumer.username,

Review comment:
       IMHO, we can use `info` level error log, therefore we can check it without `log_level('debug')`. `debug` is too low to check it in the production if needed.

##########
File path: t/plugin/basic-auth.t
##########
@@ -189,6 +190,7 @@ Authorization: Basic Zm9vOmZvbwo=
 
 
 === TEST 8: verify
+--- yaml_config eval: $::yaml_config

Review comment:
       We don't need this line?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org