[GitHub] [camel-quarkus] ppalaga commented on pull request #4359: Ref #4358: Java jOOR DSL native support

[GitBox <gi...@apache.org>]

ppalaga commented on PR #4359:
URL: https://github.com/apache/camel-quarkus/pull/4359#issuecomment-1368209404

   @essobedo very nice! I have left some minor questions and comments inline.
   
   In addition to that, I'd vote for 
   
   * Removing the dependency on quarkus-resteasy-jsonb in the test. We generally prefer a minimal set of dependencies in integration tests to avoid the risk that the additional dependency fixes some native issue in the test, but otherwise the extension under test would not work without it. We have seen this happening with quarkus-resteasy-jackson, maybe it would not happen with quarkus-resteasy-jsonb, but anyway, it is easy to do without by splitting to context lookups into multiple REST endpoints as I tried to implement here: https://github.com/ppalaga/camel-quarkus/commit/ef0361fe28c261c5d621fc2ab07433c58a4aa7a3#diff-050e5976f7d86cda20a440f5326cc7fd3f6dbe5ae9f52700c53329a4da1033f7R46-R73
   * Adding a test that checks that the jOOR route really works - something like this: https://github.com/ppalaga/camel-quarkus/commit/ef0361fe28c261c5d621fc2ab07433c58a4aa7a3#diff-050e5976f7d86cda20a440f5326cc7fd3f6dbe5ae9f52700c53329a4da1033f7R75-R81
   
   If you like the above proposal feel free to amend the commit https://github.com/ppalaga/camel-quarkus/commit/ef0361fe28c261c5d621fc2ab07433c58a4aa7a3 to this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org