You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "kerneltime (via GitHub)" <gi...@apache.org> on 2024/01/29 20:11:20 UTC
[PR] HDDS-10229: Fixes for dashboards [ozone]
kerneltime opened a new pull request, #6120:
URL: https://github.com/apache/ozone/pull/6120
## What changes were proposed in this pull request?
There are some fixes needed for various dashboards published.
Details are in the linked jira.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10229
## How was this patch tested?
Dashboard was imported to my dev cluster and validated against load generation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10229. Fixes for dashboards [ozone]
Posted by "tanvipenumudy (via GitHub)" <gi...@apache.org>.
tanvipenumudy commented on code in PR #6120:
URL: https://github.com/apache/ozone/pull/6120#discussion_r1471034621
##########
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - ListKey Metrics.json:
##########
@@ -77,7 +69,7 @@
{
"datasource": {
"type": "prometheus",
- "uid": "${DS_PROMETHEUS-1}"
+ "uid": "${DS_PROMETHEUS}"
Review Comment:
While adding a new dashboard (by importing the `.json` file) and selecting the Prometheus source, I can see the graphs. However, when attempting to view graphs for the existing dashboards, I encounter the error message: `Datasource ${DS_PROMETHEUS} was not found` (by default).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10229. Fixes for dashboards [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #6120:
URL: https://github.com/apache/ozone/pull/6120#discussion_r1470236285
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/reconciliation.sdt:
##########
Review Comment:
I think this empty file is unintentionally added to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10229. Fixes for dashboards [ozone]
Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime commented on code in PR #6120:
URL: https://github.com/apache/ozone/pull/6120#discussion_r1470370264
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/reconciliation.sdt:
##########
Review Comment:
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10229. Fixes for dashboards [ozone]
Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime commented on code in PR #6120:
URL: https://github.com/apache/ozone/pull/6120#discussion_r1482018098
##########
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - ListKey Metrics.json:
##########
@@ -77,7 +69,7 @@
{
"datasource": {
"type": "prometheus",
- "uid": "${DS_PROMETHEUS-1}"
+ "uid": "${DS_PROMETHEUS}"
Review Comment:
I was able to reproduce the issue. It only impacts the pre provisioned Dashboards in the dev environment but should be ok for any customer importing a dashboard. I will update with the fix that makes it work for both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10229. Fixes for dashboards [ozone]
Posted by "PhilippeLan (via GitHub)" <gi...@apache.org>.
PhilippeLan commented on code in PR #6120:
URL: https://github.com/apache/ozone/pull/6120#discussion_r1535596423
##########
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - ListKey Metrics.json:
##########
@@ -77,7 +69,7 @@
{
"datasource": {
"type": "prometheus",
- "uid": "${DS_PROMETHEUS-1}"
+ "uid": "${DS_PROMETHEUS}"
Review Comment:
Dear ozone comiters,
The latest Grafana is depreciating certain visual currently used within the current object-metrics dashboard.
I've updated upon recent expectation hope this helps.
Grafaa version Grafana v10.4.0 (03f502a94d)
[Ozone - Object Metrics update dahsboards.json](https://github.com/apache/ozone/files/14723282/Ozone.-.Object.Metrics.update.dahsboards.json)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10229. Fixes for dashboards [ozone]
Posted by "tanvipenumudy (via GitHub)" <gi...@apache.org>.
tanvipenumudy commented on code in PR #6120:
URL: https://github.com/apache/ozone/pull/6120#discussion_r1471034621
##########
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - ListKey Metrics.json:
##########
@@ -77,7 +69,7 @@
{
"datasource": {
"type": "prometheus",
- "uid": "${DS_PROMETHEUS-1}"
+ "uid": "${DS_PROMETHEUS}"
Review Comment:
While adding a new dashboard (by importing the `.json` file) and selecting the Prometheus source, I can see the graphs. However, when attempting to view graphs for the existing dashboards, I encounter the error message: `Datasource ${DS_PROMETHEUS} was not found`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10229. Fixes for dashboards [ozone]
Posted by "tanvipenumudy (via GitHub)" <gi...@apache.org>.
tanvipenumudy commented on code in PR #6120:
URL: https://github.com/apache/ozone/pull/6120#discussion_r1470623723
##########
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - ListKey Metrics.json:
##########
@@ -77,7 +69,7 @@
{
"datasource": {
"type": "prometheus",
- "uid": "${DS_PROMETHEUS-1}"
+ "uid": "${DS_PROMETHEUS}"
Review Comment:
`Datasource ${DS_PROMETHEUS} was not found`
I have checked out the patch locally and tried viewing the dashboards using Graphana via a docker-compose cluster with the monitoring add-ons, the variable: `DS_PROMETHEUS` does not get resolved automatically - not sure if it has something to do with my local settings! (please find the image attached).
I tried removing the `uid` field under `datasource` after which I do not run into this issue - I get to see the graphs as expected.
```
"datasource": {
"type": "prometheus"
},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10229. Fixes for dashboards [ozone]
Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime commented on code in PR #6120:
URL: https://github.com/apache/ozone/pull/6120#discussion_r1470678407
##########
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - ListKey Metrics.json:
##########
@@ -77,7 +69,7 @@
{
"datasource": {
"type": "prometheus",
- "uid": "${DS_PROMETHEUS-1}"
+ "uid": "${DS_PROMETHEUS}"
Review Comment:
Did you import it as a new dashboard?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10229. Fixes for dashboards [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #6120:
URL: https://github.com/apache/ozone/pull/6120#issuecomment-1933376451
Thanks @kerneltime for the patch, @duongkame, @tanvipenumudy for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10229. Fixes for dashboards [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #6120:
URL: https://github.com/apache/ozone/pull/6120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10229. Fixes for dashboards [ozone]
Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime commented on code in PR #6120:
URL: https://github.com/apache/ozone/pull/6120#discussion_r1482057619
##########
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - ListKey Metrics.json:
##########
@@ -77,7 +69,7 @@
{
"datasource": {
"type": "prometheus",
- "uid": "${DS_PROMETHEUS-1}"
+ "uid": "${DS_PROMETHEUS}"
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10229. Fixes for dashboards [ozone]
Posted by "PhilippeLan (via GitHub)" <gi...@apache.org>.
PhilippeLan commented on code in PR #6120:
URL: https://github.com/apache/ozone/pull/6120#discussion_r1535596423
##########
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - ListKey Metrics.json:
##########
@@ -77,7 +69,7 @@
{
"datasource": {
"type": "prometheus",
- "uid": "${DS_PROMETHEUS-1}"
+ "uid": "${DS_PROMETHEUS}"
Review Comment:
Dear ozone comiters,
The latest Grafana is depreciating certain visual currently used within the current object-metrics dashboard.
I've updated upon recent expectation hope this helps.
[Ozone - Object Metrics update dahsboards.json](https://github.com/apache/ozone/files/14723282/Ozone.-.Object.Metrics.update.dahsboards.json)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10229. Fixes for dashboards [ozone]
Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime commented on code in PR #6120:
URL: https://github.com/apache/ozone/pull/6120#discussion_r1537936810
##########
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - ListKey Metrics.json:
##########
@@ -77,7 +69,7 @@
{
"datasource": {
"type": "prometheus",
- "uid": "${DS_PROMETHEUS-1}"
+ "uid": "${DS_PROMETHEUS}"
Review Comment:
Thanks @PhilippeLan will include these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org