You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "AstraHoo (via GitHub)" <gi...@apache.org> on 2024/12/27 03:31:58 UTC
[PR] [CALCITE-6747] Multiple SLF4J bindings in Spark unit test [calcite]
AstraHoo opened a new pull request, #4114:
URL: https://github.com/apache/calcite/pull/4114
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6747] Multiple SLF4J bindings in Spark unit test [calcite]
Posted by "AstraHoo (via GitHub)" <gi...@apache.org>.
AstraHoo commented on code in PR #4114:
URL: https://github.com/apache/calcite/pull/4114#discussion_r1898363754
##########
spark/build.gradle.kts:
##########
@@ -31,5 +31,5 @@ dependencies {
runtimeOnly("xerces:xercesImpl")
testImplementation(project(":testkit"))
- testRuntimeOnly("org.apache.logging.log4j:log4j-slf4j-impl")
+ testRuntimeOnly("org.slf4j:slf4j-reload4j")
Review Comment:
@ILuffZhe Hi,I have added the CI reports before and after the modification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6747] Multiple SLF4J bindings in Spark unit test [calcite]
Posted by "AstraHoo (via GitHub)" <gi...@apache.org>.
AstraHoo commented on code in PR #4114:
URL: https://github.com/apache/calcite/pull/4114#discussion_r1898362611
##########
spark/build.gradle.kts:
##########
@@ -31,5 +31,5 @@ dependencies {
runtimeOnly("xerces:xercesImpl")
testImplementation(project(":testkit"))
- testRuntimeOnly("org.apache.logging.log4j:log4j-slf4j-impl")
+ testRuntimeOnly("org.slf4j:slf4j-reload4j")
Review Comment:
Before:
SparkAdapterTest > testFilterTrue() STANDARD_ERROR
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/Users/hubinhua/.gradle/caches/modules-2/files-2.1/org.apache.logging.log4j/log4j-slf4j-impl/2.17.1/84692d456bcce689355d33d68167875e486954dd/log4j-slf4j-impl-2.17.1.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/Users/hubinhua/.gradle/caches/modules-2/files-2.1/org.slf4j/slf4j-reload4j/1.7.36/db708f7d959dee1857ac524636e85ecf2e1781c1/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.apache.logging.slf4j.Log4jLoggerFactory]
After:
SparkAdapterTest > testOrderByLimit() STANDARD_OUT
2024-12-27 08:31:25,429 [ForkJoinPool-1-worker-4] INFO - Your platform does not provide complete low-level API for accessing direct buffers reliably. Unless explicitly requested, heap buffer will always be preferred to avoid potential system unstability.
2.7sec, org.apache.calcite.test.SparkAdapterTest > testFilterFalse()
2.7sec, org.apache.calcite.test.SparkAdapterTest > testFilterTrue()
2.7sec, org.apache.calcite.test.SparkAdapterTest > testOrderByLimit()
2.8sec, org.apache.calcite.test.SparkAdapterTest > testSortXDescYDescProjectY()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6747] Multiple SLF4J bindings in Spark unit test [calcite]
Posted by "ILuffZhe (via GitHub)" <gi...@apache.org>.
ILuffZhe commented on code in PR #4114:
URL: https://github.com/apache/calcite/pull/4114#discussion_r1898217250
##########
spark/build.gradle.kts:
##########
@@ -31,5 +31,5 @@ dependencies {
runtimeOnly("xerces:xercesImpl")
testImplementation(project(":testkit"))
- testRuntimeOnly("org.apache.logging.log4j:log4j-slf4j-impl")
+ testRuntimeOnly("org.slf4j:slf4j-reload4j")
Review Comment:
Can you add the environment reports in JIRA after this change？ I think that will be more intuitive for others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6747] Multiple SLF4J bindings in Spark unit test [calcite]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #4114:
URL: https://github.com/apache/calcite/pull/4114#issuecomment-2565205107
@ILuffZhe It might not be possible to drop the log4j dependency from Pig. I vaguely remember that there were strong dependencies to log4j classes from within Pig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6747] Multiple SLF4J bindings in Spark unit test [calcite]
Posted by "ILuffZhe (via GitHub)" <gi...@apache.org>.
ILuffZhe commented on PR #4114:
URL: https://github.com/apache/calcite/pull/4114#issuecomment-2563502687
There are also some `multiple SLF4J bingings` in pig adapter, can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6747] Multiple SLF4J bindings in Spark unit test [calcite]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #4114:
URL: https://github.com/apache/calcite/pull/4114#issuecomment-2623769934
This seems pretty much ready, I will take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6747] Multiple SLF4J bindings in Spark unit test [calcite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4114:
URL: https://github.com/apache/calcite/pull/4114#issuecomment-2623444007
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@calcite.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6747] Multiple SLF4J bindings in Spark unit test [calcite]
Posted by "AstraHoo (via GitHub)" <gi...@apache.org>.
AstraHoo commented on PR #4114:
URL: https://github.com/apache/calcite/pull/4114#issuecomment-2563500917
The test cases for SparkAdapter Test are executed concurrently in a thread pool, so these functions ,testOrderByLimit(),testFilterFalse(),testFilterTrue(),testOrderByLimit(),testSortXDescYDescProjectY(),may not necessarily come first, but the exception will disappear after modification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6747] Multiple SLF4J bindings in Spark unit test [calcite]
Posted by "AstraHoo (via GitHub)" <gi...@apache.org>.
AstraHoo commented on code in PR #4114:
URL: https://github.com/apache/calcite/pull/4114#discussion_r1898363754
##########
spark/build.gradle.kts:
##########
@@ -31,5 +31,5 @@ dependencies {
runtimeOnly("xerces:xercesImpl")
testImplementation(project(":testkit"))
- testRuntimeOnly("org.apache.logging.log4j:log4j-slf4j-impl")
+ testRuntimeOnly("org.slf4j:slf4j-reload4j")
Review Comment:
@ILuffZhe Hi,
I have added the CI reports before and after the modification.Everyone can verify by retrieving testFilterTrue() from the CI report or local Gradle log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6747] Multiple SLF4J bindings in Spark unit test [calcite]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak closed pull request #4114: [CALCITE-6747] Multiple SLF4J bindings in Spark unit test
URL: https://github.com/apache/calcite/pull/4114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org