[GitHub] [spark] iRakson commented on a change in pull request #27648: [SPARK-24994][SQL] : Support filter pushdown for short and byte without explicit casting

[GitBox <gi...@apache.org>]

iRakson commented on a change in pull request #27648: [SPARK-24994][SQL] : Support filter pushdown for short and byte without explicit casting
URL: https://github.com/apache/spark/pull/27648#discussion_r385685847
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ##########
 @@ -1802,3 +1803,85 @@ object OptimizeLimitZero extends Rule[LogicalPlan] {
       empty(ll)
   }
 }
+
+/**
+ * Removes Cast expressions from predicates to push down the filters. This will allow filter push
+ * down for byte and short columns without explicitly casting literals.
 
 Review comment:
   In this solution i am not generalising casting. This PR only deals with Byte and Short columns and Values are only downcasted in case they are within byte/short range. Otherwise whole Predicate is left unchanged. 
   Also before pushing i am explicitly checking whether these values can be pushed down or not. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org