You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/10/26 11:45:39 UTC

[GitHub] [airflow] feluelle commented on issue #6431: [AIRFLOW-XXX] Fix type annotation for external task sensor

feluelle commented on issue #6431: [AIRFLOW-XXX] Fix type annotation for external task sensor
URL: https://github.com/apache/airflow/pull/6431#issuecomment-546595467
 
 
   > But should we also change the function definition is a good question, actually :-)
   
   That's really a (somehow) tough question.
   I would personally say 
   ~~yes, because using `None`` as default is quite common.~~ 
   ~~no, because actually we want the user to define a task_id according to the class name.~~
   yes. :D
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services