You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/06/02 06:44:37 UTC
[GitHub] [incubator-dolphinscheduler] itbasketplayer opened a new pull request #2857: add job history to judge application status #2625
itbasketplayer opened a new pull request #2857:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2857
## What is the purpose of the pull request
add job history status url to judge application status, when application number threshold is reached(default 10000,maybe it was set to 1000).
you can see issue #2625
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #2857: add job history to judge application status #2625
Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #2857:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2857#issuecomment-637314317
> it is my problem?
you are right
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] itbasketplayer commented on pull request #2857: add job history to judge application status #2625
Posted by GitBox <gi...@apache.org>.
itbasketplayer commented on pull request #2857:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2857#issuecomment-662806559
ok,i will do it on weekends :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong closed pull request #2857: add job history to judge application status #2625
Posted by GitBox <gi...@apache.org>.
dailidong closed pull request #2857:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2857
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] itbasketplayer commented on pull request #2857: add job history to judge application status #2625
Posted by GitBox <gi...@apache.org>.
itbasketplayer commented on pull request #2857:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2857#issuecomment-637222136
it is my problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on pull request #2857: add job history to judge application status #2625
Posted by GitBox <gi...@apache.org>.
qiaozhanwei commented on pull request #2857:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2857#issuecomment-657944719
submit this PR to dev branch. Thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] chengshiwen commented on pull request #2857: add job history to judge application status #2625
Posted by GitBox <gi...@apache.org>.
chengshiwen commented on pull request #2857:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2857#issuecomment-748446026
duplicated with [#2848]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] lgcareer commented on pull request #2857: add job history to judge application status #2625
Posted by GitBox <gi...@apache.org>.
lgcareer commented on pull request #2857:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2857#issuecomment-678869356
@itbasketplayer Hi,thanks for you contribution,you can resend the pr to the dev branch,And if you resent,you can paste the pr url here,then we will review the pr on dev and close this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #2857: add job history to judge application status #2625
Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #2857:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2857#issuecomment-751264031
> duplicated with [#2848], so thir pr should be closed.
I will close this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on pull request #2857: add job history to judge application status #2625
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #2857:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2857#issuecomment-692467811
Hi, please resolve the conflict.. If there is no update after 7 days, the PR will be closed, and you can reopen it when your problem is resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] itbasketplayer commented on a change in pull request #2857: add job history to judge application status #2625
Posted by GitBox <gi...@apache.org>.
itbasketplayer commented on a change in pull request #2857:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2857#discussion_r434454177
##########
File path: dolphinscheduler-common/src/main/resources/common.properties
##########
@@ -18,47 +18,49 @@
# resource storage type : HDFS,S3,NONE
resource.storage.type=NONE
-# resource store on HDFS/S3 path, resource file will store to this hadoop hdfs path, self configuration, please make sure the directory exists on hdfs and have read write permissions。"/dolphinscheduler" is recommended
-resource.upload.path=/dolphinscheduler
+# resource store on HDFS/S3 path, resource file will store to this hadoop hdfs path, self configuration, please make sure the directory exists on hdfs and have read write permissions."/dolphinscheduler" is recommended
+#resource.upload.path=/dolphinscheduler
# user data local directory path, please make sure the directory exists and have read write permissions
#data.basedir.path=/tmp/dolphinscheduler
# whether kerberos starts
-hadoop.security.authentication.startup.state=false
+#hadoop.security.authentication.startup.state=false
# java.security.krb5.conf path
-java.security.krb5.conf.path=/opt/krb5.conf
+#java.security.krb5.conf.path=/opt/krb5.conf
# login user from keytab username
-login.user.keytab.username=hdfs-mycluster@ESZ.COM
+#login.user.keytab.username=hdfs-mycluster@ESZ.COM
# loginUserFromKeytab path
-login.user.keytab.path=/opt/hdfs.headless.keytab
+#login.user.keytab.path=/opt/hdfs.headless.keytab
#resource.view.suffixs
#resource.view.suffixs=txt,log,sh,conf,cfg,py,java,sql,hql,xml,properties
# if resource.storage.type=HDFS, the user need to have permission to create directories under the HDFS root path
hdfs.root.user=hdfs
-# if resource.storage.type=S3，the value like: s3a://dolphinscheduler ; if resource.storage.type=HDFS, When namenode HA is enabled, you need to copy core-site.xml and hdfs-site.xml to conf dir
+# if resource.storage.type=S3,the value like: s3a://dolphinscheduler ; if resource.storage.type=HDFS, When namenode HA is enabled, you need to copy core-site.xml and hdfs-site.xml to conf dir
fs.defaultFS=hdfs://mycluster:8020
-# if resource.storage.type=S3，s3 endpoint
-fs.s3a.endpoint=http://192.168.xx.xx:9010
+# if resource.storage.type=S3,s3 endpoint
+#fs.s3a.endpoint=http://192.168.199.91:9010
-# if resource.storage.type=S3，s3 access key
-fs.s3a.access.key=A3DXS30FO22544RE
+# if resource.storage.type=S3,s3 access key
+#fs.s3a.access.key=A3DXS30FO22544RE
-# if resource.storage.type=S3，s3 secret key
-fs.s3a.secret.key=OloCLq3n+8+sdPHUhJ21XrSxTC+JK
+# if resource.storage.type=S3,s3 secret key
+#fs.s3a.secret.key=OloCLq3n+8+sdPHUhJ21XrSxTC+JK
Review comment:
it is idea format code :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] lgcareer edited a comment on pull request #2857: add job history to judge application status #2625
Posted by GitBox <gi...@apache.org>.
lgcareer edited a comment on pull request #2857:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2857#issuecomment-678869356
@itbasketplayer Hi,thanks for you contribution,you can resend the pr to the dev branch,And if you resent,you can paste the pr url here,then the pr on dev will be reviewd and this pr will be closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #2857: add job history to judge application status #2625
Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #2857:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2857#issuecomment-637317125
> > it is my problem?
>
> you are right
sorry，accidentally closed the question， reopen again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] itbasketplayer closed pull request #2857: add job history to judge application status #2625
Posted by GitBox <gi...@apache.org>.
itbasketplayer closed pull request #2857:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2857
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] itbasketplayer commented on pull request #2857: add job history to judge application status #2625
Posted by GitBox <gi...@apache.org>.
itbasketplayer commented on pull request #2857:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2857#issuecomment-638146998
@dailidong should reopen again? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong closed pull request #2857: add job history to judge application status #2625
Posted by GitBox <gi...@apache.org>.
dailidong closed pull request #2857:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2857
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #2857: add job history to judge application status #2625
Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #2857:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2857#issuecomment-653737758
sorry for review so late，could you submit this PR content to dev branch ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #2857: add job history to judge application status #2625
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #2857:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2857#issuecomment-668510816
Hi,
Please resolve the conflict. Thx a lot~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #2857: add job history to judge application status #2625
Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #2857:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2857#issuecomment-658036888
sorry for not merge into dev-1.3.1
could you submit this PR to dev branch ?
sorry again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] chengshiwen edited a comment on pull request #2857: add job history to judge application status #2625
Posted by GitBox <gi...@apache.org>.
chengshiwen edited a comment on pull request #2857:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2857#issuecomment-748446026
duplicated with [#2848], so thir pr should be closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on a change in pull request #2857: add job history to judge application status #2625
Posted by GitBox <gi...@apache.org>.
dailidong commented on a change in pull request #2857:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2857#discussion_r433653457
##########
File path: dolphinscheduler-common/src/main/resources/common.properties
##########
@@ -18,47 +18,49 @@
# resource storage type : HDFS,S3,NONE
resource.storage.type=NONE
-# resource store on HDFS/S3 path, resource file will store to this hadoop hdfs path, self configuration, please make sure the directory exists on hdfs and have read write permissions。"/dolphinscheduler" is recommended
-resource.upload.path=/dolphinscheduler
+# resource store on HDFS/S3 path, resource file will store to this hadoop hdfs path, self configuration, please make sure the directory exists on hdfs and have read write permissions."/dolphinscheduler" is recommended
+#resource.upload.path=/dolphinscheduler
# user data local directory path, please make sure the directory exists and have read write permissions
#data.basedir.path=/tmp/dolphinscheduler
# whether kerberos starts
-hadoop.security.authentication.startup.state=false
+#hadoop.security.authentication.startup.state=false
# java.security.krb5.conf path
-java.security.krb5.conf.path=/opt/krb5.conf
+#java.security.krb5.conf.path=/opt/krb5.conf
# login user from keytab username
-login.user.keytab.username=hdfs-mycluster@ESZ.COM
+#login.user.keytab.username=hdfs-mycluster@ESZ.COM
# loginUserFromKeytab path
-login.user.keytab.path=/opt/hdfs.headless.keytab
+#login.user.keytab.path=/opt/hdfs.headless.keytab
#resource.view.suffixs
#resource.view.suffixs=txt,log,sh,conf,cfg,py,java,sql,hql,xml,properties
# if resource.storage.type=HDFS, the user need to have permission to create directories under the HDFS root path
hdfs.root.user=hdfs
-# if resource.storage.type=S3，the value like: s3a://dolphinscheduler ; if resource.storage.type=HDFS, When namenode HA is enabled, you need to copy core-site.xml and hdfs-site.xml to conf dir
+# if resource.storage.type=S3,the value like: s3a://dolphinscheduler ; if resource.storage.type=HDFS, When namenode HA is enabled, you need to copy core-site.xml and hdfs-site.xml to conf dir
fs.defaultFS=hdfs://mycluster:8020
-# if resource.storage.type=S3，s3 endpoint
-fs.s3a.endpoint=http://192.168.xx.xx:9010
+# if resource.storage.type=S3,s3 endpoint
+#fs.s3a.endpoint=http://192.168.199.91:9010
-# if resource.storage.type=S3，s3 access key
-fs.s3a.access.key=A3DXS30FO22544RE
+# if resource.storage.type=S3,s3 access key
+#fs.s3a.access.key=A3DXS30FO22544RE
-# if resource.storage.type=S3，s3 secret key
-fs.s3a.secret.key=OloCLq3n+8+sdPHUhJ21XrSxTC+JK
+# if resource.storage.type=S3,s3 secret key
+#fs.s3a.secret.key=OloCLq3n+8+sdPHUhJ21XrSxTC+JK
Review comment:
why comment these lines?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org