You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Jacky007 (JIRA)" <ji...@apache.org> on 2012/11/20 12:58:58 UTC
[jira] [Commented] (ZOOKEEPER-1493) C Client: zookeeper_process
doesn't invoke completion callback if zookeeper_close has been called
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501128#comment-13501128 ]
Jacky007 commented on ZOOKEEPER-1493:
-------------------------------------
this patch also solve a potential hang int zookeeper_close() :-)
> C Client: zookeeper_process doesn't invoke completion callback if zookeeper_close has been called
> -------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1493
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1493
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.4.3, 3.3.5
> Reporter: Michi Mutsuzaki
> Assignee: Michi Mutsuzaki
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1493_3_3.patch, ZOOKEEPER-1493_3_4.patch, ZOOKEEPER-1493.patch
>
>
> In ZOOKEEPER-804, we added a check in zookeeper_process() to see if zookeeper_close() has been called. This was to avoid calling assert(cptr) on a NULL pointer, as dequeue_completion() returns NULL if the sent_requests queue has been cleared by free_completion() from zookeeper_close(). However, we should still call the completion if it is not NULL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira