error numbers and their scope (was: Re: svn commit: r30716 - in branches/dont-save-plaintext-passwords-by-default/subversion: include libsvn_subr)

[Stefan Sperling <st...@elego.de>]

On Sat, Apr 19, 2008 at 05:11:38PM -0700, David Glasser wrote:
> By the way, I guess you were copying what was already there, but
> what's up with the error code SVN_ERR_RA_DAV_INVALID_CONFIG_VALUE?

Well, for all I know we don't declare new error codes all
the time, and try to reuse suitable ones wherever possible.

I remember Hyrum once renamed some SVN_ERR_WC_... error code to
a more generic name and reused it outside libsvn_wc, but subsequently
renamed the error code to SVN_ERR_WC_... again for some reason
(but kept using it).

And I found use of SVN_ERR_RA_DAV_INVALID_CONFIG_VALUE outside
of libsvn_ra_dav so I thought it might be the correct thing to use it.

Ultimately many of our error number names are bound to some
subsystem for no good reason. I think we should identify the
inherently generic ones and put them in their own category,
but current practice seems to be to simply reuse error codes
wherever we can...

-- 
Stefan Sperling <st...@elego.de>                    Software Monkey
 
German law requires the following banner :(
elego Software Solutions GmbH                            HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12        Tel:  +49 30 23 45 86 96 
13355 Berlin                              Fax:  +49 30 23 45 86 95
http://www.elego.de                               CEO: Olaf Wagner
 
Store password unencrypted (yes/no)? No