You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/22 17:22:58 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #12548: Restructure the extras and described them

potiuk commented on a change in pull request #12548:
URL: https://github.com/apache/airflow/pull/12548#discussion_r528365633



##########
File path: setup.py
##########
@@ -826,7 +822,7 @@ def is_package_excluded(package: str, exclusion_list: List[str]):
 
 EXTRAS_REQUIREMENTS.update(
     {
-        'all': devel_all,

Review comment:
       It definitely can. It definitely needs UPDATING.md and MOVE_TO_2.0 updates.
   
   We are using the "[all]" already in a few places where we expect also the "devel" to be installed (just look for "[all]") 
   
   For example in:
   
   * dev/provider_packages/README.md
   * script/in_container/_in_container_utils.sh
   * in scrpts in "scripts/ci/provider_packages/*.sh"  (but I am working on it now in #12512) 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org