You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "danigiri (via GitHub)" <gi...@apache.org> on 2024/11/06 14:16:24 UTC
[PR] Added EXTRACT_URL_PARAMETER to Doris parsing support (#31508) [shardingsphere]
danigiri opened a new pull request, #33571:
URL: https://github.com/apache/shardingsphere/pull/33571
Continuing with Doris parsing support.
In this case adding support for `EXTRACT_URL_PARAMETER`
see https://doris.apache.org/docs/sql-manual/sql-functions/string-functions/extract-url-parameter
No equivalent mysql function i could find.
Continues to address #31508
### Changes proposed in this pull request:
- added test
- Marked // DORIS ADDED BEGIN|END
- added parser g4 stuff, within `extractUrlParameterFunction`
- added visitor logic as needed
- ran spotless
- ran (though will check again once committed and do a full test)
```
cd test/it/parser/
mvn -DskipTests=true generate-sources compile install -q
cd parser/sql/dialect/doris/
mvn test -Dit.test=InternalDorisParserIT
```
### Next
- Add change to release notes
- Run full tests on test machine (running)
### Question
- do we collapse two consecutive changes? So
```
// DORIS ADDED END
// DORIS ADDED BEGIN
```
would be
```
```
and have a final terminating
`// DORIS ADDED END`
at the end
---
Before committing this PR, I'm sure that I have checked the following options:
- [✅] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [✅] I have self-reviewed the commit code.
- [✅] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [✅] I have added corresponding unit tests for my changes.
- [✅] mvn spotless:apply -Pcheck
- [✅] mvn test -Dit.test=InternalDorisParserIT in shardingsphere/parser/sql/dialect/doris (need to specify it.test)
- [✅] Executed test case in Doris v2.1.6 – `SELECT EXTRACT_URL_PARAMETER('http://foo.com/?bar=baz','bar')`
```
+---------------------------------------------------------+
| extract_url_parameter('http://foo.com/?bar=baz', 'bar') |
+---------------------------------------------------------+
| baz |
+---------------------------------------------------------+
1 row in set (0.31 sec)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added EXTRACT_URL_PARAMETER to Doris parsing support (#31508) [shardingsphere]
Posted by "danigiri (via GitHub)" <gi...@apache.org>.
danigiri commented on PR #33571:
URL: https://github.com/apache/shardingsphere/pull/33571#issuecomment-2487007248
@strongduanmu can you check? release notes should be OK now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added EXTRACT_URL_PARAMETER to Doris parsing support (#31508) [shardingsphere]
Posted by "danigiri (via GitHub)" <gi...@apache.org>.
danigiri commented on PR #33571:
URL: https://github.com/apache/shardingsphere/pull/33571#issuecomment-2471230846
Ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added EXTRACT_URL_PARAMETER to Doris parsing support (#31508) [shardingsphere]
Posted by "danigiri (via GitHub)" <gi...@apache.org>.
danigiri commented on PR #33571:
URL: https://github.com/apache/shardingsphere/pull/33571#issuecomment-2499170882
XML test files have drifted since the PR was created, will resolve conflicts tomorrow morning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added EXTRACT_URL_PARAMETER to Doris parsing support (#31508) [shardingsphere]
Posted by "danigiri (via GitHub)" <gi...@apache.org>.
danigiri commented on PR #33571:
URL: https://github.com/apache/shardingsphere/pull/33571#issuecomment-2487005645
Sure, it is probably the release notes have drifted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added EXTRACT_URL_PARAMETER to Doris parsing support (#31508) [shardingsphere]
Posted by "danigiri (via GitHub)" <gi...@apache.org>.
danigiri commented on PR #33571:
URL: https://github.com/apache/shardingsphere/pull/33571#issuecomment-2461829624
found the correct test indexes, will commit tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added EXTRACT_URL_PARAMETER to Doris parsing support (#31508) [shardingsphere]
Posted by "danigiri (via GitHub)" <gi...@apache.org>.
danigiri commented on PR #33571:
URL: https://github.com/apache/shardingsphere/pull/33571#issuecomment-2471001542
Could complete full test cycle on test machine, next is to incorporate latest upstream changes and should be OK for final review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added EXTRACT_URL_PARAMETER to Doris parsing support (#31508) [shardingsphere]
Posted by "danigiri (via GitHub)" <gi...@apache.org>.
danigiri commented on PR #33571:
URL: https://github.com/apache/shardingsphere/pull/33571#issuecomment-2535306378
awesome, thanks @strongduanmu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added EXTRACT_URL_PARAMETER to Doris parsing support (#31508) [shardingsphere]
Posted by "danigiri (via GitHub)" <gi...@apache.org>.
danigiri commented on PR #33571:
URL: https://github.com/apache/shardingsphere/pull/33571#issuecomment-2459961786
Will check the test failures. Looks like the combo:
```
cd test/it/parser/
mvn -DskipTests=true generate-sources compile install -q
cd parser/sql/dialect/doris/
mvn test -Dit.test=InternalDorisParserIT
```
doesn't fully test as expected. Currently fully testing on my test server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added EXTRACT_URL_PARAMETER to Doris parsing support (#31508) [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #33571:
URL: https://github.com/apache/shardingsphere/pull/33571#issuecomment-2484542281
Hi @danigiri, can you solve code conflict?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added EXTRACT_URL_PARAMETER to Doris parsing support (#31508) [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #33571:
URL: https://github.com/apache/shardingsphere/pull/33571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added EXTRACT_URL_PARAMETER to Doris parsing support (#31508) [shardingsphere]
Posted by "danigiri (via GitHub)" <gi...@apache.org>.
danigiri commented on PR #33571:
URL: https://github.com/apache/shardingsphere/pull/33571#issuecomment-2500170598
As expected, it was test file drift, merged and running checks ATM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org