You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2018/11/07 20:36:54 UTC
[GitHub] ctubbsii commented on a change in pull request #752: Fixes #747 -
Shorten method names in AccumuloClient builder
ctubbsii commented on a change in pull request #752: Fixes #747 - Shorten method names in AccumuloClient builder
URL: https://github.com/apache/accumulo/pull/752#discussion_r231667657
##########
File path: core/src/main/java/org/apache/accumulo/core/client/AccumuloClient.java
##########
@@ -377,7 +378,7 @@ AccumuloClient changeUser(String principal, AuthenticationToken token)
* Path to properties file
* @return this builder
*/
- AccumuloClientFactory usingProperties(String propertiesFile);
+ AccumuloClientFactory from(CharSequence propertiesFile);
Review comment:
I think this should be Path or File (probably Path).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services