You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/05 11:37:42 UTC
[GitHub] [doris] jackwener opened a new pull request, #10624: [enhancement]: remove redundant field.
jackwener opened a new pull request, #10624:
URL: https://github.com/apache/doris/pull/10624
# Proposed changes
Issue Number: close #10616
## Problem Summary:
Remove the redundant field in `TSortNode` which exist in `TSortInfo`.
[API-BREAK] This has changed `Thrift` file.
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No Need)
3. Has document been added or modified: (No Need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10624: [enhancement]: remove redundant field.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10624:
URL: https://github.com/apache/doris/pull/10624#issuecomment-1177648449
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] EmmyMiao87 commented on a diff in pull request #10624: [enhancement]: remove redundant field.
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on code in PR #10624:
URL: https://github.com/apache/doris/pull/10624#discussion_r914616469
##########
gensrc/thrift/PlanNodes.thrift:
##########
@@ -573,17 +573,8 @@ struct TSortNode {
// This is the number of rows to skip before returning results
3: optional i64 offset
- // TODO(lingbin): remove blew, because duplaicate with TSortInfo
Review Comment:
The upgrade process is generally a rolling upgrade. This means that there may be phases of a higher version of be and a lower version of fe. Are your changes compatible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener commented on pull request #10624: [enhancement]: remove redundant field.
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #10624:
URL: https://github.com/apache/doris/pull/10624#issuecomment-1178764697
In addition, This PR will not influent the upgrade. Because deleted field is optional
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10624: [enhancement]: remove redundant field.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10624:
URL: https://github.com/apache/doris/pull/10624#issuecomment-1177648508
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] EmmyMiao87 merged pull request #10624: [enhancement]: remove redundant field.
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 merged PR #10624:
URL: https://github.com/apache/doris/pull/10624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org